Touchpad KCM QtQuickControls2 Conversion
ClosedPublic
Actions

kcms/touchpad/src/kcm/libinput/main.qml
23 ↗	(On Diff #36236)	this is either unused or wrong
37 ↗	(On Diff #36236)	Saying the size hint is the size it currently is looks wrong generally speaking: width propagates from parent to child implicitWidth propagates from child to parent

mart requested changes to this revision.Jun 18 2018, 10:37 AM

mart added a subscriber: mart.

mart added inline comments.

kcms/touchpad/src/kcm/libinput/main.qml
23 ↗	(On Diff #36236)	he's using qqc1 tooltips, they should be ported as well.
37 ↗	(On Diff #36236)	and what those sizehint properties are used for at all? they look wrong, you either have implicitwidth/height or Layout.minimum/preferred/maximumwidth and height. implementing yourself hints should generally never be done as it will break very easily
285 ↗	(On Diff #36236)	i guess this is the thing that comes from styles 1.4 there is also a qqc2 ToolTip element, which is the one that should be used

This revision now requires changes to proceed.Jun 18 2018, 10:37 AM

@davidedmundson @mart
Thanks for the feedback. New patch is coming.

V0.2

Converted everything to qqc2.
SizeHint is corrected.
ToolTip.qml is deleted since qqc2 has built-in support for ToolTip as we want.
Tested. Overviewed all code.
Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

Harbormaster completed remote builds in B107: Diff 36308.Jun 19 2018, 8:17 AM

QML-wise looks ok for me now, still wait for Roman's accept as well.

Looks good to me too.

In D13573#279852, @furkantokac wrote:

Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

That would be unrelated to this code cleanup. Please do that in another patch.

In D13573#280026, @ngraham wrote:

Looks good to me too.

In D13573#279852, @furkantokac wrote:

Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

That would be unrelated to this code cleanup. Please do that in another patch.

So its okay no problem. Thanks for the feedback.

ngraham mentioned this in D13672: Mouse KCM Pointer Speed Slider Improvement.Jun 22 2018, 1:22 PM

romangg accepted this revision.Jun 24 2018, 7:33 PM

romangg added inline comments.

kcms/touchpad/src/kcm/libinput/main.qml
202	typo

This revision is now accepted and ready to land.Jun 24 2018, 7:33 PM

Typo fix.

Harbormaster completed remote builds in B302: Diff 36648.Jun 25 2018, 6:23 PM

Ship it!

Closed by commit R119:6a4b5870fb2f: Touchpad KCM QtQuickControls2 Conversion (authored by furkantokac). · Explain WhyJun 25 2018, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
D	M	kcms/touchpad/src/kcm/libinput/components/ExclGroupBox.qml (57 lines)
D	M	kcms/touchpad/src/kcm/libinput/components/ToolTip.qml (52 lines)
M		kcms/touchpad/src/kcm/libinput/main.qml (299 lines)
M		kcms/touchpad/src/kcm/resources.qrc (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	36236	03f5e41		Jun 16 2018, 5:38 PM	★	★
Diff 2	36308	03f5e41	V0.2	Jun 19 2018, 8:17 AM	★	★
Diff 3	36648	03f5e41	Typo fix.	Jun 25 2018, 6:23 PM	★	★
Diff 4	36649	ea21521	R119:6a4b5870fb2ff918df9e5b8f708e8039b394177e	Jun 25 2018, 6:30 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
afb6ebbefbc9	c7a82ec5994a	e6c5c2f756bf	Furkan Tokac	Converted everything to qqc2. SizeHint is corrected. Tested.	Jun 19 2018, 8:14 AM
e6c5c2f756bf	3e2201807d00	03f5e4103252	Furkan Tokac	Touchpad KCM QtQuickControls2 Conversion (Show More…)	Jun 16 2018, 5:37 PM