Touchpad KCM QtQuickControls2 Conversion
ClosedPublic

Authored by furkantokac on Jun 16 2018, 5:38 PM.

Details

Summary

Tested. Working fine. Functionality is same.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 302
Build 302: arc lint + arc unit
furkantokac created this revision.Jun 16 2018, 5:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 16 2018, 5:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
furkantokac requested review of this revision.Jun 16 2018, 5:38 PM
furkantokac edited the summary of this revision. (Show Details)Jun 16 2018, 5:42 PM
furkantokac added reviewers: romangg, ngraham.
davidedmundson added inline comments.
kcms/touchpad/src/kcm/libinput/main.qml
22–23

this is either unused or wrong

34

Saying the size hint is the size it currently is looks wrong

generally speaking:

width propagates from parent to child
implicitWidth propagates from child to parent

mart requested changes to this revision.Jun 18 2018, 10:37 AM
mart added a subscriber: mart.
mart added inline comments.
kcms/touchpad/src/kcm/libinput/main.qml
22–23

he's using qqc1 tooltips, they should be ported as well.

34

and what those sizehint properties are used for at all? they look wrong,
you either have implicitwidth/height or Layout.minimum/preferred/maximumwidth and height.
implementing yourself hints should generally never be done as it will break very easily

289

i guess this is the thing that comes from styles 1.4
there is also a qqc2 ToolTip element, which is the one that should be used

This revision now requires changes to proceed.Jun 18 2018, 10:37 AM

@davidedmundson @mart
Thanks for the feedback. New patch is coming.

furkantokac updated this revision to Diff 36308.EditedJun 19 2018, 8:17 AM

V0.2

  • Converted everything to qqc2.
  • SizeHint is corrected.
  • ToolTip.qml is deleted since qqc2 has built-in support for ToolTip as we want.
  • Tested. Overviewed all code.
  • Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.
mart accepted this revision as: mart.Jun 19 2018, 8:56 AM

QML-wise looks ok for me now, still wait for Roman's accept as well.

ngraham accepted this revision.Jun 19 2018, 12:52 PM

Looks good to me too.

  • Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

That would be unrelated to this code cleanup. Please do that in another patch.

Looks good to me too.

  • Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

That would be unrelated to this code cleanup. Please do that in another patch.

So its okay no problem. Thanks for the feedback.

romangg accepted this revision.Jun 24 2018, 7:33 PM
romangg added inline comments.
kcms/touchpad/src/kcm/libinput/main.qml
202

typo

This revision is now accepted and ready to land.Jun 24 2018, 7:33 PM
ngraham accepted this revision.Jun 25 2018, 6:27 PM

Ship it!

This revision was automatically updated to reflect the committed changes.