furkantokac (Furkan Tokac)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2018, 4:11 PM (64 w, 3 d)
Availability
Available

Recent Activity

Dec 28 2018

furkantokac updated the task description for T9177: Splitting Touchpad KCM.
Dec 28 2018, 3:15 AM · Plasma
furkantokac updated the task description for T9177: Splitting Touchpad KCM.
Dec 28 2018, 12:22 AM · Plasma

Aug 11 2018

furkantokac added a comment to T9177: Splitting Touchpad KCM.

Hey guys I'm back.

Aug 11 2018, 2:22 PM · Plasma

Jul 10 2018

furkantokac updated the task description for T9177: Splitting Touchpad KCM.
Jul 10 2018, 5:48 PM · Plasma
furkantokac retitled D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder from KConfigModule Wayland Touchpad KCM is Created in "touchpad" Folder to Dummy Wayland Touchpad KCM is Created in "touchpad" Folder.
Jul 10 2018, 5:48 PM · Plasma
furkantokac updated the test plan for D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder.
Jul 10 2018, 5:47 PM · Plasma
furkantokac updated the task description for T9177: Splitting Touchpad KCM.
Jul 10 2018, 4:58 PM · Plasma
furkantokac updated the test plan for D14016: Files in "touchpad" Moved To The New Folder "touchpadx".
Jul 10 2018, 4:56 PM · Plasma
furkantokac updated the test plan for D13997: Removing Wayland Part of Touchpad KCM.
Jul 10 2018, 4:47 PM · Plasma
furkantokac triaged T9177: Splitting Touchpad KCM as Normal priority.
Jul 10 2018, 4:45 PM · Plasma

Jul 9 2018

furkantokac updated the summary of D14016: Files in "touchpad" Moved To The New Folder "touchpadx".
Jul 9 2018, 11:34 PM · Plasma
furkantokac updated the summary of D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder.
Jul 9 2018, 11:34 PM · Plasma
furkantokac added reviewers for D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder: ngraham, romangg, Plasma.
Jul 9 2018, 11:33 PM · Plasma
furkantokac added a dependency for D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder: D14016: Files in "touchpad" Moved To The New Folder "touchpadx".
Jul 9 2018, 11:32 PM · Plasma
furkantokac added a dependent revision for D14016: Files in "touchpad" Moved To The New Folder "touchpadx": D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder.
Jul 9 2018, 11:32 PM · Plasma
furkantokac requested review of D14017: Dummy Wayland Touchpad KCM is Created in "touchpad" Folder.
Jul 9 2018, 11:08 PM · Plasma
furkantokac added a dependency for D14016: Files in "touchpad" Moved To The New Folder "touchpadx": D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 11:04 PM · Plasma
furkantokac added a dependent revision for D13997: Removing Wayland Part of Touchpad KCM: D14016: Files in "touchpad" Moved To The New Folder "touchpadx".
Jul 9 2018, 11:04 PM · Plasma
furkantokac added reviewers for D14016: Files in "touchpad" Moved To The New Folder "touchpadx": ngraham, romangg, Plasma.
Jul 9 2018, 11:04 PM · Plasma
furkantokac requested review of D14016: Files in "touchpad" Moved To The New Folder "touchpadx".
Jul 9 2018, 11:02 PM · Plasma
furkantokac updated the diff for D13997: Removing Wayland Part of Touchpad KCM.

Phase 1

Jul 9 2018, 10:53 PM · Plasma
furkantokac updated the test plan for D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 3:59 PM · Plasma
furkantokac added a comment to D13997: Removing Wayland Part of Touchpad KCM.

If we go with this split the stages should be:

  1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X code as kcm_touchpad.
  2. Remove all Wayland related code from the old KCM.
  3. Rewrite the new Wayland KCM as KConfigModule.
  4. Your stage 4.
Jul 9 2018, 3:56 PM · Plasma
furkantokac updated the diff for D13997: Removing Wayland Part of Touchpad KCM.

Stage 3
kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. Tested and working fine. To test it, you should manually remove the old kcm_touchpad files since the names are clashing imho. This problem will be handled by packagers after the patch is pushed to master. I'm implementing the backend now (kcm.cpp, kcm.h).

Jul 9 2018, 3:54 PM · Plasma
furkantokac updated the test plan for D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 9:48 AM · Plasma
furkantokac updated the diff for D13997: Removing Wayland Part of Touchpad KCM.

Stage 2 :
Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new folder "touchpadx". Since "touchpad" folder is changed, you can review the diff by checking it. Tested on X and everything is working fine. In Wayland, the KCM is not shown at all.

Jul 9 2018, 9:45 AM · Plasma
furkantokac updated the summary of D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 8:55 AM · Plasma
furkantokac updated the summary of D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 8:48 AM · Plasma
furkantokac updated the summary of D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 8:42 AM · Plasma
furkantokac updated the summary of D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 8:37 AM · Plasma
furkantokac added a comment to D13997: Removing Wayland Part of Touchpad KCM.

Since you can review the old diff, I'm moving to stage 2. If you have problem with the Stage 1's diff, please tell me.

Jul 9 2018, 8:02 AM · Plasma
furkantokac added a reviewer for D13997: Removing Wayland Part of Touchpad KCM: Plasma.
Jul 9 2018, 8:01 AM · Plasma
furkantokac added reviewers for D13997: Removing Wayland Part of Touchpad KCM: romangg, ngraham.
Jul 9 2018, 7:55 AM · Plasma
furkantokac requested review of D13997: Removing Wayland Part of Touchpad KCM.
Jul 9 2018, 7:54 AM · Plasma

Jun 27 2018

furkantokac committed R119:86e674c6a2b9: Touchpad KCM Pointer Speed Slider Improvement (authored by furkantokac).
Touchpad KCM Pointer Speed Slider Improvement
Jun 27 2018, 10:28 PM
furkantokac closed D13767: Touchpad KCM Pointer Speed Slider Improvement.
Jun 27 2018, 10:28 PM · Plasma
furkantokac updated the diff for D13767: Touchpad KCM Pointer Speed Slider Improvement.

Comment correction.

Jun 27 2018, 10:25 PM · Plasma
furkantokac updated the diff for D13767: Touchpad KCM Pointer Speed Slider Improvement.

"value" part of last "Slider" patch is reverted since that kind of changes will be handled with another patch.

Jun 27 2018, 7:45 PM · Plasma
furkantokac added inline comments to D13767: Touchpad KCM Pointer Speed Slider Improvement.
Jun 27 2018, 7:39 PM · Plasma
furkantokac added reviewers for D13767: Touchpad KCM Pointer Speed Slider Improvement: ngraham, romangg, Plasma.
Jun 27 2018, 7:20 PM · Plasma
furkantokac requested review of D13767: Touchpad KCM Pointer Speed Slider Improvement.
Jun 27 2018, 7:18 PM · Plasma

Jun 26 2018

furkantokac committed R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement (authored by furkantokac).
Mouse KCM Pointer Speed Slider Improvement
Jun 26 2018, 8:13 PM
furkantokac closed D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 26 2018, 8:13 PM · Plasma
furkantokac updated the summary of D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 26 2018, 7:54 PM · Plasma

Jun 25 2018

furkantokac added a comment to D13672: Mouse KCM Pointer Speed Slider Improvement.

BUG: 395681 can't be a link, I don't think. It's gotta just be plain old dumb text. :)

This patch actually solves the problem specified on bug title, "libinput pointer kcm needs 11 ticks on the speed slider so that the middle one can correspond to 0.0". Still you think that it doesn't solve the bug ?

Jun 25 2018, 6:36 PM · Plasma
furkantokac committed R119:6a4b5870fb2f: Touchpad KCM QtQuickControls2 Conversion (authored by furkantokac).
Touchpad KCM QtQuickControls2 Conversion
Jun 25 2018, 6:30 PM
furkantokac closed D13573: Touchpad KCM QtQuickControls2 Conversion.
Jun 25 2018, 6:30 PM · Plasma
furkantokac updated the diff for D13573: Touchpad KCM QtQuickControls2 Conversion.

Typo fix.

Jun 25 2018, 6:23 PM · Plasma

Jun 22 2018

furkantokac updated the summary of D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 22 2018, 7:54 AM · Plasma
furkantokac updated the summary of D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 22 2018, 7:53 AM · Plasma
furkantokac updated the summary of D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 22 2018, 7:52 AM · Plasma
furkantokac added reviewers for D13672: Mouse KCM Pointer Speed Slider Improvement: ngraham, romangg, Plasma.
Jun 22 2018, 7:51 AM · Plasma
furkantokac requested review of D13672: Mouse KCM Pointer Speed Slider Improvement.
Jun 22 2018, 7:40 AM · Plasma

Jun 19 2018

furkantokac added a comment to D13573: Touchpad KCM QtQuickControls2 Conversion.

Looks good to me too.

  • Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.

That would be unrelated to this code cleanup. Please do that in another patch.

Jun 19 2018, 12:54 PM · Plasma
furkantokac updated the diff for D13573: Touchpad KCM QtQuickControls2 Conversion.

V0.2

  • Converted everything to qqc2.
  • SizeHint is corrected.
  • ToolTip.qml is deleted since qqc2 has built-in support for ToolTip as we want.
  • Tested. Overviewed all code.
  • Please review it. After your review, I'll also enable the Acceleration Profile with this patch by some editing.
Jun 19 2018, 8:17 AM · Plasma

Jun 18 2018

furkantokac added a comment to D13573: Touchpad KCM QtQuickControls2 Conversion.

@davidedmundson @mart
Thanks for the feedback. New patch is coming.

Jun 18 2018, 4:33 PM · Plasma

Jun 16 2018

furkantokac added reviewers for D13573: Touchpad KCM QtQuickControls2 Conversion: romangg, ngraham.
Jun 16 2018, 5:42 PM · Plasma
furkantokac requested review of D13573: Touchpad KCM QtQuickControls2 Conversion.
Jun 16 2018, 5:38 PM · Plasma

Jun 14 2018

furkantokac added a comment to T8854: Smooth Screen Brightness Level Transition.

It would be very nice! I have things to do that will take 1-2 month. If nobody interested till then, please ping to me. I can work on it.

Jun 14 2018, 9:58 PM · Plasma, VDG
furkantokac removed a watcher for VDG: furkantokac.
Jun 14 2018, 9:52 PM
furkantokac removed a watcher for Plasma: KCM Redesign: furkantokac.
Jun 14 2018, 9:49 PM
This is a test notification, sent at Fri, Jun 15, 12:42 AM.
Jun 14 2018, 9:42 PM

Jun 13 2018

furkantokac closed T8978: Mouse as Resolved.
Jun 13 2018, 10:11 PM · Plasma: KCM Redesign
furkantokac added a watcher for Plasma: KCM Redesign: furkantokac.
Jun 13 2018, 10:09 PM
furkantokac added a watcher for VDG: furkantokac.
Jun 13 2018, 10:08 PM
furkantokac committed R119:e4ce025aa706: Mouse KCM Redesign Using Kirigami (authored by furkantokac).
Mouse KCM Redesign Using Kirigami
Jun 13 2018, 9:39 PM
furkantokac closed D13372: Mouse KCM Redesign Using Kirigami.
Jun 13 2018, 9:39 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.6
Wayland version (main.qml) is tested (X was already tested). Corrections are done. Functionality is same. All the possibilities are tested. Works fine. Ready to push.

Jun 13 2018, 9:10 PM · Plasma

Jun 12 2018

furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 12 2018, 5:12 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.5
import org.kde.plasma.core is removed for main.qml.

Jun 12 2018, 5:11 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.4
QtQuickControls version is updated to 2.0. Some code cleaning.

Jun 12 2018, 5:02 PM · Plasma

Jun 11 2018

furkantokac added a comment to T8985: KCM Template in QML.

Let me know if I can help with anything

Jun 11 2018, 11:34 PM · Plasma: KCM Redesign
furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.
In D13372#277078, @mart wrote:

here a patch against this which ports it to qqc2, using the completely different radiobutton mechanics qqc2 uses, fixing separators, removing plasmacore import


with qqc2-desktop-style master, the spacing issues should be solved

Jun 11 2018, 1:35 PM · Plasma
furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.
In D13372#277040, @mart wrote:

for me, using qqc1 in a new kcm, is an absolute blocker, no matter what the problem is with qqc2, problems must be fixed, not worked around. ever.

Jun 11 2018, 10:33 AM · Plasma
furkantokac claimed T8985: KCM Template in QML.
Jun 11 2018, 10:09 AM · Plasma: KCM Redesign

Jun 10 2018

furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.4
Stupid mistake that I have done is fixed. Thank you romangg.

Jun 10 2018, 9:34 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.3
sizeHint and minimumSizeHint are added.

Jun 10 2018, 6:37 PM · Plasma
furkantokac updated the task description for T8985: KCM Template in QML.
Jun 10 2018, 9:03 AM · Plasma: KCM Redesign
furkantokac updated the task description for T8985: KCM Template in QML.
Jun 10 2018, 8:55 AM · Plasma: KCM Redesign
furkantokac triaged T8985: KCM Template in QML as High priority.
Jun 10 2018, 7:50 AM · Plasma: KCM Redesign
furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.

If everyone is happy and the patch is tested, I'll push the code after a last test for Wayland and Xorg.

Jun 10 2018, 1:32 AM · Plasma
furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 10 2018, 1:30 AM · Plasma
furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 10 2018, 1:30 AM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.2
After a discussion, decided to go back to V0.2 because of some UI issues. Bug reports will be filed about the issues. For now, we'll use qqc1.

Jun 10 2018, 1:30 AM · Plasma

Jun 9 2018

furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.

Just realized that paddings look bad in QQC2. Any recommendation ?

Jun 9 2018, 11:24 PM · Plasma
furkantokac added inline comments to D13372: Mouse KCM Redesign Using Kirigami.
Jun 9 2018, 11:02 PM · Plasma
furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 9 2018, 10:19 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

V0.3
QtQuickControls version is updated to 2.0. Some code cleaning.

Jun 9 2018, 9:43 PM · Plasma
furkantokac updated the test plan for D13372: Mouse KCM Redesign Using Kirigami.
Jun 9 2018, 9:41 PM · Plasma
furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.

Small question, why we're not using QQC2-based controls?

Jun 9 2018, 2:52 PM · Plasma

Jun 8 2018

furkantokac updated the task description for T8978: Mouse.
Jun 8 2018, 11:43 AM · Plasma: KCM Redesign
furkantokac triaged T8978: Mouse as Normal priority.
Jun 8 2018, 11:43 AM · Plasma: KCM Redesign

Jun 7 2018

furkantokac added a comment to D13372: Mouse KCM Redesign Using Kirigami.

Please test the code and if everyone is happy, I'll push the code.

Jun 7 2018, 11:00 PM · Plasma
furkantokac added inline comments to D13372: Mouse KCM Redesign Using Kirigami.
Jun 7 2018, 10:58 PM · Plasma
furkantokac updated the diff for D13372: Mouse KCM Redesign Using Kirigami.

Update V0.2
Page is converted to ScrollablePage. ExclGroupBox converted to RadioButton since the titling is issue with ExclGroupBox + ScrollablePage. Middle-click title is updated.

Jun 7 2018, 10:53 PM · Plasma
furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 7 2018, 10:45 PM · Plasma

Jun 6 2018

furkantokac updated the summary of D13372: Mouse KCM Redesign Using Kirigami.
Jun 6 2018, 4:34 AM · Plasma
furkantokac added reviewers for D13372: Mouse KCM Redesign Using Kirigami: ngraham, romangg.
Jun 6 2018, 1:05 AM · Plasma
furkantokac requested review of D13372: Mouse KCM Redesign Using Kirigami.
Jun 6 2018, 1:00 AM · Plasma

Jun 5 2018

furkantokac updated the summary of D13141: Touchpad KCM Redesign Using Kirigami.
Jun 5 2018, 12:04 AM · Plasma