Use collapsible box to configure visible roles
ClosedPublic

Authored by elvisangelaccio on Jun 16 2018, 3:40 PM.

Details

Summary

A modal dialog that opens another modal dialog is bad UX and should be
avoided whenever possible. These days we have KCollapsibleGroupBox
that can be used to show advanced settings without cluttering the
default layout.

This change removes the AdditionalInfoDialog and uses a collapsible
groupbox instead. The Apply buttons gets enabled whenever a role gets
checked or unchecked, consistently with the existing checkboxes.

Test Plan

Change visible roles in the view properties dialog.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 16 2018, 3:40 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Jun 16 2018, 3:40 PM

Some screens:

global view props:

per-folder view props:

ngraham accepted this revision as: VDG.Jun 18 2018, 1:01 PM
ngraham added a subscriber: ngraham.

A big improvement, usability-wise!

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 26, 8:16 PM
This revision was automatically updated to reflect the committed changes.