Use collapsible box to configure visible roles

Authored by elvisangelaccio on Jun 26 2018, 8:13 PM.

Description

Use collapsible box to configure visible roles

Summary:
A modal dialog that opens another modal dialog is bad UX and should be
avoided whenever possible. These days we have KCollapsibleGroupBox
that can be used to show advanced settings without cluttering the
default layout.

This change removes the AdditionalInfoDialog and uses a collapsible
groupbox instead. The Apply buttons gets enabled whenever a role gets
checked or unchecked, consistently with the existing checkboxes.

Test Plan: Change visible roles in the view properties dialog.

Reviewers: Dolphin, VDG

Reviewed By: VDG

Subscribers: ngraham, kfm-devel

Tags: Dolphin

Differential Revision: https://phabricator.kde.org/D13569

Details

Committed
elvisangelaccioJun 26 2018, 8:13 PM
Reviewer
VDG
Differential Revision
D13569: Use collapsible box to configure visible roles
Parents
R318:9b7ceaa74da3: don't use temporaries when uneeded
Branches
Unknown
Tags
Unknown