If a user has set his border size explicitly in the past also respect this
selection with the new auto border size mode by setting auto borders to
false on update.
For this a kconf_update file and a sed based shell script is added.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Maniphest Tasks
- T8707: Window borders
- Commits
- R108:d3ad6bc0b97c: kconfig_update for auto border size introduction
Manually.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| helpers/kconf_update/kwin-5.14-auto-bordersize.sh | ||
|---|---|---|
| 3 ↗ | (On Diff #36008) | You can use kconf_update to do most the work for you with File=kwinrc " If the Script command was issued after a Group command the behavior is slightly different: All entries from <oldfile>/<oldgroup> are piped into <_script>. The output of script is used as new entries for <newfile>/<newgroup>, unless a different group is specified with [group]. Existing entries can be deleted from <oldgroup> by adding lines with #DELETE key |
Comment Actions
That's a trillion times more readable ++
I don't get why you're checking for BorderSizeAuto as you're adding that at the same time as you're adding this update file, so you know no-one will have it set...but it's fine.
(obviously don't push it without the other patches)
| helpers/kconf_update/kwin-5.14-auto-bordersize.sh | ||
|---|---|---|
| 16 ↗ | (On Diff #36020) | The docs imply you don't need to do this. |