Differential D13433

Introduce ActionToolbar
ClosedPublic
Actions

Authored by mart on Jun 8 2018, 4:10 PM.

Details

Reviewers
hein
Group Reviewers
Kirigami
Commits
R169:2b8fab409fcd: first prototype of ActionToolbar and port usage
R169:fd8fb834843c: remove the dead code
R169:4dd77fe05499: document flat
R169:40f0967da478: Introduce ActionToolbar
Summary

A toolbar which represents a list of actions with a series of ToolButtons.
When there is not enough space for all the toolbuttons, put some of them under a menu triggered by a "..." overflow button

port Card and InlineMessage private implementations to this

Test Plan

Card and InlineMessage have the same behavior

Diff Detail

Repository
R169 Kirigami
Branch
mart/actiontoolbar
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Jun 8 2018, 4:10 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 8 2018, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Jun 8 2018, 4:10 PM
mart updated this revision to Diff 35847.
  • document flat
mart retitled this revision from first prototype of ActionToolbar and port usage to Introduce ActionToolbar.Jun 8 2018, 4:13 PM
mart edited the summary of this revision. (Show Details)
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Kirigami, hein.

davidedmundson added a subscriber: davidedmundson.Jun 8 2018, 6:13 PM

Did you fix your binding loop?

apol added a subscriber: apol.Jun 8 2018, 11:08 PM

+1 makes a lot of sense.

mart added a comment.Jun 9 2018, 9:51 AM
In D13433#275932, @davidedmundson wrote:

Did you fix your binding loop?

yeah.. now its size hints are slightly oversized to accomodate the optional extra "..." button, which is not 100% optimal but since buttons are fillwidth it looks fine and doesn't loop

hein accepted this revision.Jun 14 2018, 10:10 AM
This revision is now accepted and ready to land.Jun 14 2018, 10:10 AM
davidedmundson added inline comments.Jun 14 2018, 10:14 AM
src/controls/ActionToolBar.qml
31

No it doesn't?

Closed by commit R169:fd8fb834843c: remove the dead code (authored by mart). · Explain WhyJun 14 2018, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
AMsrc/controls/ActionToolBar.qml (151 lines)

Diff 35847

View Options

src/controls/ActionToolBar.qml

Loading...