Introduce ActionToolbar
ClosedPublic

Authored by mart on Jun 8 2018, 4:10 PM.

Details

Summary

A toolbar which represents a list of actions with a series of ToolButtons.
When there is not enough space for all the toolbuttons, put some of them under a menu triggered by a "..." overflow button

port Card and InlineMessage private implementations to this

Test Plan

Card and InlineMessage have the same behavior

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jun 8 2018, 4:10 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJun 8 2018, 4:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Jun 8 2018, 4:10 PM
mart updated this revision to Diff 35847.
  • document flat
mart retitled this revision from first prototype of ActionToolbar and port usage to Introduce ActionToolbar.Jun 8 2018, 4:13 PM
mart edited the summary of this revision. (Show Details)
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Kirigami, hein.

Did you fix your binding loop?

apol added a subscriber: apol.Jun 8 2018, 11:08 PM

+1 makes a lot of sense.

mart added a comment.Jun 9 2018, 9:51 AM

Did you fix your binding loop?

yeah.. now its size hints are slightly oversized to accomodate the optional extra "..." button, which is not 100% optimal but since buttons are fillwidth it looks fine and doesn't loop

hein accepted this revision.Jun 14 2018, 10:10 AM
This revision is now accepted and ready to land.Jun 14 2018, 10:10 AM
src/controls/ActionToolBar.qml
31

No it doesn't?

This revision was automatically updated to reflect the committed changes.