Updated handles and overflow-menu-*
ClosedPublic
Actions

Authored by alex-l on May 26 2018, 5:44 PM.

Details

Reviewers

mart
andreask
andreaska
hein
ngraham

Summary

Added the icons in the image as 22px in both Breeze and Breeze Dark, support for system color scheme included, SVGs cleaned.

Now handle-{right;left} symlink point to overflow-menu-{right;left}. In future these symlink could be removed or replaced with different icons without touching the overflow-menu ones.

Diff Detail

Repository

R266 Breeze Icons

Lint

Lint Skipped

Unit

Unit Tests Skipped

alex-l created this revision.May 26 2018, 5:44 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMay 26 2018, 5:44 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

alex-l requested review of this revision.May 26 2018, 5:44 PM

alex-l edited the summary of this revision. (Show Details)

+1 from me, exactly what was needed!
any definitive ship it from other vdg people

andreask accepted this revision.May 28 2018, 8:27 AM

This revision is now accepted and ready to land.May 28 2018, 8:27 AM

hein accepted this revision.May 28 2018, 10:05 AM

Still not totally thrilled about overflow-menu-left and overflow-menu-right, but I'm willing to give 'em a shot and see how it goes. All the other ones are fantastic IMHO. Let's ship it!

In D13137#269807, @ngraham wrote:

Still not totally thrilled about overflow-menu-left and overflow-menu-right, but I'm willing to give 'em a shot and see how it goes. All the other ones are fantastic IMHO. Let's ship it!

to me, they should probably keep the old names, handle-right and handle-left, if nothing else to not make names in breeze icons explode, having icons left in there that are on all effects, deprecated

mart closed this revision.May 31 2018, 10:12 AM

Revision Contents
Changeset List

		Path
A	M	icons-dark/actions/22/drag-surface.svg (16 lines)
M		icons-dark/actions/22/handle-left.svg (2 lines)
A	M	icons-dark/actions/22/handle-move.svg (16 lines)
M	M	icons-dark/actions/22/handle-right.svg (1 line)
A	M	icons-dark/actions/22/handle-sort.svg (16 lines)
A	M	icons-dark/actions/22/overflow-menu-left.svg (15 lines)
A	M	icons-dark/actions/22/overflow-menu-right.svg (16 lines)
A	M	icons/actions/22/drag-surface.svg (16 lines)
M		icons/actions/22/handle-left.svg (2 lines)
A	M	icons/actions/22/handle-move.svg (16 lines)
M	M	icons/actions/22/handle-right.svg (1 line)
A	M	icons/actions/22/handle-sort.svg (16 lines)
A	M	icons/actions/22/overflow-menu-left.svg (15 lines)
A	M	icons/actions/22/overflow-menu-right.svg (16 lines)