Element trees can be added as well, but without this, only the root element was
handled.
Details
Details
- Reviewers
broulik davidedmundson - Group Reviewers
Plasma - Commits
- R856:0db2416dc351: Handle children of added nodes as well
Videos on twitter get registered now.
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Sweet!
I think it used to have this but it caused trouble due to DOM traversal with complex sites. The old code walked the entire DOM every time whereas you just query the node that changed, so shouldn't have that big of an impact as the old one did.
@lbeltrame Can you check whether this causes trouble with the massive table you had issues with?
| extension/content-script.js | ||
|---|---|---|
| 357–361 | if (typeof node.querySelectorAll !== "function") | |
Comment Actions
What's the easiest way to test this? I might just patch the package and see what happens.
Comment Actions
git clone the repo and load an unpacked extension at the /extension (deactivate/uninstall the other version first).
You can't really patch a .crx.