[QuickShare] Respect units.iconSizeHints.panel for panel icon

Authored by Zren on May 14 2018, 1:14 AM.


Test Plan
  1. Add QuickShare and ShowDesktop widgets to a wide panel.
  2. System Settings > Icons > Advanced > Panel > 22px
  3. Confirm ShowDesktop respects icon size, while QuickShare does not.
  4. Install patched version of QuickShare + restart plasmashell.
  5. Confirm both respect icon size.

Diff Detail

R114 Plasma Addons
Lint Skipped
Unit Tests Skipped
Zren created this revision.May 14 2018, 1:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 14 2018, 1:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Zren requested review of this revision.May 14 2018, 1:14 AM



Unrelated change

apol requested changes to this revision.May 14 2018, 10:57 AM

Looks good to me, please fix the comment Kay mentioned so we can land the change.

This revision now requires changes to proceed.May 14 2018, 10:57 AM
Zren updated this revision to Diff 34138.May 14 2018, 1:30 PM

Remove unrelated brace formatting.

If there's nothing else, I'll merge it this evening.

broulik accepted this revision.May 14 2018, 2:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 14 2018, 7:32 PM
This revision was automatically updated to reflect the committed changes.