Differential D12831

Don't automatically set the default icons for each style
ClosedPublic
Actions

Authored by ngraham on May 11 2018, 10:56 PM.

Details

Reviewers
cullmann
cfeck
Commits
R236:f213aa037f65: Don't automatically set the default icons for each style
Summary

When re-doing the visual style of the KMessageWidget, I inappropriately added a call to automatically set the default icons. This patch corrects that error.

Test Plan

Tested Konsole, Kate, Spectacle, and Dolphin. All is the way it was before my prior patch, and Kate's inline messages (for example) no longer have icons.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.May 11 2018, 10:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 11 2018, 10:56 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.May 11 2018, 10:56 PM
cfeck accepted this revision.May 11 2018, 11:11 PM
cfeck added a subscriber: cfeck.

Somehow I didn't notice you added those, but I have seen rejections to this, so please commit this revert.

This revision is now accepted and ready to land.May 11 2018, 11:11 PM
Closed by commit R236:f213aa037f65: Don't automatically set the default icons for each style (authored by ngraham). · Explain WhyMay 11 2018, 11:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagewidget.cpp (4 lines)

Diff 34004

View Options

src/kmessagewidget.cpp

Loading...