Make KMessageWidget match Kirigami inlineMessage's style

Authored by ngraham on Apr 25 2018, 12:48 PM.

Description

Make KMessageWidget match Kirigami inlineMessage's style

Summary:
This patch makes the venerable and wonderful KMessageWidget match the slick style of Kirigami's new inlineMessage control. As a by-product, it fixes a few usability bugs.

I didn't implement the drop shadow here because I couldn't get it to look right.

BUG: 385299
BUG: 381255

Test Plan:
Spectacle, Breeze light, information:

Spectacle, Breeze dark, information:

Spectacle, Breeze light, positive:

Spectacle, Breeze dark, positive:

Dolphin, Breeze light, negative:

Dolphin, Breeze dark, negative:

Dolphin, Breeze light, warning:

Konsole, Breeze light with dark profile theme, warning:

Konsole, Breeze dark with light profile theme, information:

Konsole, Breeze light, information:

Kate, Breeze light, positive:

Kate, Breeze dark, information:

Reviewers: hein, Plasma, VDG, elvisangelaccio, cfeck

Reviewed By: hein, Plasma, cfeck

Subscribers: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, Frameworks

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D12508

Ah, found my comments in a different browser tab :-P

/src/kmessagewidget.h
45

I think it would be nice to possibly update this screenshot?
See: https://api.kde.org/frameworks/kwidgetsaddons/html/classKMessageWidget.html

206

Unfortunately, I am late to the game: The patch is not good enough: Now this comment is wrong, and in fact, you changed behavior implying all applications get icons where possibly not wanted.

In Kate for instance, we do not want any icon in "10 replacements made" or "Search wrapped", since the icon does not contribute anything except eating space :-/