Usage of Phonon is already optional in the source code; this commit updates the CMake file to reflect this. All tests pass with Phonon missing.
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
CMakeLists.txt | ||
---|---|---|
68 ↗ | (On Diff #33526) | there are no component, why do you use this keyword ? removing 'REQUIRED' was enough |
CMakeLists.txt | ||
---|---|---|
68 ↗ | (On Diff #33526) | I added this keyword because Qt5TTS has it too. Anyways, how do I *update* a patch on this thing? Do I just use “Abandon Revision” from the drop-down below and start over? |
If you want to update the patch on phabricator, just apply it locally with arc patch Dxyzt, amend the git commit as usual (maybe also rebase on master if needed), and use arc diff again.
I used the web interface and I wasn't able to find the „Update Diff“ button (why not update patch or update commit?) in the right box until now. It should be fixed now.
Updated to latest KF5 version and probably fixed the issue mentioned in review – although I have no idea what it was.
CMakeLists.txt | ||
---|---|---|
79 | What about this comment? |
CMakeLists.txt | ||
---|---|---|
79 | Well, it isn't actually required and it compiles just fine with both canberra and phonon missing. |