ntninja (Alexander Schlarb)
Animal

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 15 2017, 8:14 PM (333 w, 2 d)
Availability
Available

Recent Activity

Feb 5 2019

ntninja added a comment to D18696: Update `libdbusmenuqt` and the AppMenu plugin.

@Zren: Updated! Thanks for pointing this out!

Feb 5 2019, 9:19 PM · Plasma
ntninja updated the diff for D18696: Update `libdbusmenuqt` and the AppMenu plugin.
Feb 5 2019, 9:13 PM · Plasma

Feb 3 2019

ntninja requested review of D18696: Update `libdbusmenuqt` and the AppMenu plugin.
Feb 3 2019, 2:42 PM · Plasma

Nov 24 2018

ntninja added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

Thanks, I'll keep that in mind for next time.

Nov 24 2018, 2:53 PM · Frameworks

Nov 23 2018

ntninja abandoned D17113: Allow disabling KPackage install while building Breeze.

Thanks for the feedback, I've looked some more into what the KPackage does and I agree that it doesn't make sense to disable it in general. Closing this.

Nov 23 2018, 11:02 AM · Plasma
ntninja added a comment to D17112: Allow disabling the build of the file dialog component.

But what if my application runs sandboxed in the desktop and does its file selection through portals? I'd still want it to have maximum desktop integration under KDE if possible. Hence I want to include plasma-integration as well, or is my thinking wrong here?

Nov 23 2018, 10:44 AM · Plasma
ntninja added inline comments to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
Nov 23 2018, 10:23 AM · Frameworks

Nov 22 2018

ntninja requested review of D17113: Allow disabling KPackage install while building Breeze.
Nov 22 2018, 10:39 PM · Plasma
ntninja requested review of D17112: Allow disabling the build of the file dialog component.
Nov 22 2018, 10:11 PM · Plasma
ntninja added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

Since these changes have been approved and marked read-to-land for quite some time, could this please be done soon? Thank you!

Nov 22 2018, 8:46 PM · Frameworks
ntninja added a reviewer for D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file: kde-frameworks-devel.
Nov 22 2018, 7:55 PM · Frameworks
ntninja updated the diff for D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.

Updated to latest KF5 version and probably fixed the issue mentioned in review – although I have no idea what it was.

Nov 22 2018, 7:54 PM · Frameworks

Jul 31 2018

ntninja added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

The target application I'm building has only very minimal dependencies on Qt (just QtCore + QtWidgets + PyQt5) and no real dependencies on KDE. The application only has a size footprint of about 6MiB, the required Qt libraries use about 10MiB of space, the selected set of KDE integration libraries (a minimalist build of the KDE plasmaintegration package including dependencies) add another 10MiB. By contrast org.kde.Platform alone adds more than 150MiB in size requirements – this is not acceptable for an app that uses less than 20% percent of its contents IMHO. You can take a look at the project here. I'm planning on making this available as a runtime extension for the FreeDesktop runtime so that other people can reuse it too.

Jul 31 2018, 1:21 PM · Frameworks
ntninja added a comment to D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available.

@ngraham: I've updated the patch to the latest GIT master of breeze. A quick test compile without qtdeclarative5-dev suggests that it still works.

Jul 31 2018, 1:06 PM · Plasma, Breeze
ntninja updated the diff for D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available.
Jul 31 2018, 1:03 PM · Plasma, Breeze

Jul 29 2018

ntninja added a comment to D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available.

That would be „Alexander Schlarb <alexander@ninetailed.ninja>“. Thanks!

Jul 29 2018, 4:17 PM · Plasma, Breeze
ntninja added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

I build a Qt app with „just enough“ KDE-integration for the Flatpak sandbox where I have no use for this KPackage stuff. I know I could just include the install handlers in the build and drop them afterwards, but that would require a build KNS (and all of *its* dependencies) as well. IMHO „only build what you use“ is surpreme in this case.

Jul 29 2018, 4:15 PM · Frameworks
ntninja added a comment to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.

Oh, I see! This wasn't obvious to me. Is this better now?

Jul 29 2018, 4:07 PM · Frameworks
ntninja set the repository for D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file to R289 KNotifications.
Jul 29 2018, 4:06 PM · Frameworks

Jul 27 2018

ntninja added a comment to D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available.

Thanks for accepting this! Please also add it to the code repository!

Jul 27 2018, 11:39 PM · Plasma, Breeze
ntninja added a comment to D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.

Any review of this would be greatly apprechiated…

Jul 27 2018, 11:30 PM · Frameworks
ntninja added a comment to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.

Could I get a new review on this please!?

Jul 27 2018, 11:29 PM · Frameworks

May 5 2018

ntninja requested review of D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`.
May 5 2018, 4:07 PM · Frameworks
ntninja requested review of D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available.
May 5 2018, 4:00 PM · Plasma, Breeze

May 3 2018

ntninja added a comment to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.

I used the web interface and I wasn't able to find the „Update Diff“ button (why not update patch or update commit?) in the right box until now. It should be fixed now.

May 3 2018, 8:13 PM · Frameworks
ntninja updated the diff for D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
May 3 2018, 8:11 PM · Frameworks
ntninja added inline comments to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
May 3 2018, 6:59 PM · Frameworks

May 2 2018

ntninja requested review of D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
May 2 2018, 10:07 PM · Frameworks