Differential D12641

Workaround Device Notifier showing an error despite volume being mounted correctly
AbandonedPublic
Actions

Authored by mlibera on May 1 2018, 6:06 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Frameworks
Summary

For some reason a Solid::StorageAccess::setupDone signal can be
received before a device is actually mounted, resulting in kde-open5
being called with and empty path instead of a mount point.
Replace signal setupDone with accessibilityChanged to make sure
that a mount point exists.

BUG: 370975

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
mlibera created this revision.May 1 2018, 6:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 1 2018, 6:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mlibera requested review of this revision.May 1 2018, 6:06 PM
davidedmundson added a subscriber: davidedmundson.May 1 2018, 6:07 PM
This comment was removed by davidedmundson.
bruns added a subscriber: bruns.May 1 2018, 6:46 PM

-1

Coding style - you could use a lambda here
Lacking comment, as its not obvious why the code is needed
parent revision is missing ...

anthonyfieroni added a subscriber: anthonyfieroni.May 1 2018, 6:57 PM
anthonyfieroni added inline comments.
soliduiserver/deviceserviceaction.cpp
91 ↗(On Diff #33414)

Why not use it in all cases?

mlibera updated this revision to Diff 33433.May 1 2018, 8:20 PM
mlibera edited the summary of this revision. (Show Details)

@anthonyfieroni
I think it makes sense, I've tested it and it works.

@bruns
I've tried to mimic the code that was already there.
With this revised version there is no extra code, so I guess no need for comments?
I've never used phabricator and have no idea what parent revision is or what am I expected to do with it, sorry.

mlibera abandoned this revision.May 1 2018, 9:02 PM

Revision Contents
Changeset List

Diff 33433

View Options

soliduiserver/deviceserviceaction.cpp

Loading...