Replace default search bar search mode setting with dedicated shortcuts
ClosedPublic

Authored by abika on May 1 2018, 5:33 PM.

Details

Summary

And removed disabling of "Case sensitve" setting when "Start by typing" is
unchecked. Search bar can be shown not only by typing in panel.

FIXED: [ 391946 ] Default mode in 'Find in folder' is not preserved
BUG: 391946

Test Plan

Tested the shortcuts and switching between them.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.May 1 2018, 5:33 PM
abika created this revision.
abika added a comment.May 1 2018, 5:36 PM

Discussed here: https://bugs.kde.org/show_bug.cgi?id=391946

New shortcut CTRL+G for "Select"-search was chosen because it was the first free one i found and S, E, L, C, T are already taken:)

Will merge after the 2.7 release because of the string freeze.

asensi accepted this revision as: asensi.May 2 2018, 11:53 AM
asensi added a subscriber: asensi.

Thank you, Alex! For my part, my performed tests using Kubuntu 18.04 went alright, and I find it easier now to filter, to search, and to select. Great!

This revision is now accepted and ready to land.May 2 2018, 11:53 AM
martinkostolny added a subscriber: martinkostolny.

Thanks Alex! It is working as expected. And like Toni said, the behaviour is much simpler now :).

nmel requested changes to this revision.May 3 2018, 7:22 AM
nmel added a subscriber: nmel.

Thanks for working on this bug. It works as it should with direct shortcuts. I'm changing the status to Waiting so we won't forget about the string freeze.

I have one concern about a possible regression in usability. Personally, I don't use this but some users may have become accustomed to the feature. I'm talking about the default mode setting for the search-as-you-type scenario. Currently, user can select Filter as a default mode and then just type symbols to filter like in Total Commander quick search. With this patch the default mode is always set to Search and there is no workaround.

To be honest, the saved state of the combobox also feels weird given we have an option for default search-as-you-type mode. You can also see the expectation from the bug reporter on his step 4. That's why I have the following idea:

  1. Keep the "default mode" combo but re-purpose it for search-as-you-type mode.
  2. When user types a first letter on a panel, always pick the search-as-you-type mode from settings, i.e. don't save the state of the last mode used on this panel.
  3. Keep dedicated shortcuts as proposed by this change.

Please let me know if you find this proposal reasonable or not.

This revision now requires changes to proceed.May 3 2018, 7:22 AM
asensi added a comment.May 8 2018, 5:52 PM

With the proposed change: things would be better, although Nikita's way of working would be an additional advantage. Thanks!

I also think it would be better if search-as-you-type mode was configurable. On top of the proposed change of course :).

abika updated this revision to Diff 34038.May 12 2018, 6:09 PM
  • Use default search bar search mode setting always on "start by typing"
abika added a comment.May 12 2018, 6:12 PM

Oh, yes of course. I initially introduced the combobox for the "start on typing" feature and its obviously still valid for this.
Thanks for pointing this out, diff is adjusted.

From my testing, it is now working nicely. Thanks, Alex!

nmel accepted this revision.May 17 2018, 5:00 AM

Works like a charm. Thanks Alex!

New shortcut CTRL+G for "Select"-search was chosen because it was the first free one i found and S, E, L, C, T are already taken:)

Ctrl+Shift+S is available, where S is for selection. I'm also fine with the default Ctrl+G. Since users can easily remap, it's not a big deal.

This revision is now accepted and ready to land.May 17 2018, 5:00 AM
asensi accepted this revision.May 17 2018, 8:32 PM

Ctrl+Shift+S is available, where S is for selection. I'm also fine with the default Ctrl+G. Since users can easily remap, it's not a big deal.

I think the same. Thanks, Alex, and all of you!

Closed by commit R167:59574af2019d: Use default search bar search mode setting always on "start by typing" (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyMay 20 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.May 20 2018, 6:34 PM

Thanks everybody! I changed the shortcut for "select in folder" to CTRL+SHIFT+S before pushing.