And removed disabling of "Case sensitve" setting when "Start by typing" is
unchecked. Search bar can be shown not only by typing in panel.
FIXED: [ 391946 ] Default mode in 'Find in folder' is not preserved
BUG: 391946
And removed disabling of "Case sensitve" setting when "Start by typing" is
unchecked. Search bar can be shown not only by typing in panel.
FIXED: [ 391946 ] Default mode in 'Find in folder' is not preserved
BUG: 391946
Tested the shortcuts and switching between them.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Discussed here: https://bugs.kde.org/show_bug.cgi?id=391946
New shortcut CTRL+G for "Select"-search was chosen because it was the first free one i found and S, E, L, C, T are already taken:)
Will merge after the 2.7 release because of the string freeze.
Thank you, Alex! For my part, my performed tests using Kubuntu 18.04 went alright, and I find it easier now to filter, to search, and to select. Great!
Thanks Alex! It is working as expected. And like Toni said, the behaviour is much simpler now :).
Thanks for working on this bug. It works as it should with direct shortcuts. I'm changing the status to Waiting so we won't forget about the string freeze.
I have one concern about a possible regression in usability. Personally, I don't use this but some users may have become accustomed to the feature. I'm talking about the default mode setting for the search-as-you-type scenario. Currently, user can select Filter as a default mode and then just type symbols to filter like in Total Commander quick search. With this patch the default mode is always set to Search and there is no workaround.
To be honest, the saved state of the combobox also feels weird given we have an option for default search-as-you-type mode. You can also see the expectation from the bug reporter on his step 4. That's why I have the following idea:
Please let me know if you find this proposal reasonable or not.
With the proposed change: things would be better, although Nikita's way of working would be an additional advantage. Thanks!
I also think it would be better if search-as-you-type mode was configurable. On top of the proposed change of course :).
Oh, yes of course. I initially introduced the combobox for the "start on typing" feature and its obviously still valid for this.
Thanks for pointing this out, diff is adjusted.
Works like a charm. Thanks Alex!
New shortcut CTRL+G for "Select"-search was chosen because it was the first free one i found and S, E, L, C, T are already taken:)
Ctrl+Shift+S is available, where S is for selection. I'm also fine with the default Ctrl+G. Since users can easily remap, it's not a big deal.
Ctrl+Shift+S is available, where S is for selection. I'm also fine with the default Ctrl+G. Since users can easily remap, it's not a big deal.
I think the same. Thanks, Alex, and all of you!
Thanks everybody! I changed the shortcut for "select in folder" to CTRL+SHIFT+S before pushing.