Differential D12584

implement interface of Baloo to watch renamed files
ClosedPublic
Actions

Authored by mgallien on Apr 28 2018, 3:38 PM.

Details

Reviewers
astippich
Group Reviewers
Elisa
Commits
R255:282e527e93f4: implement interface of Baloo to watch renamed files
Summary

implement interface of Baloo to watch renamed files

Test Plan

automatic tests are still OK, No dedicated automatic tests

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Apr 28 2018, 3:38 PM
mgallien created this revision.
mgallien retitled this revision from implement interface of Baloo to watch renamed files to [WIP] implement interface of Baloo to watch renamed files.Apr 28 2018, 3:47 PM
mgallien edited the summary of this revision. (Show Details)

Linked to D4911 counter part in Baloo.

mgallien retitled this revision from [WIP] implement interface of Baloo to watch renamed files to implement interface of Baloo to watch renamed files.Jun 6 2018, 6:40 PM
mgallien edited the summary of this revision. (Show Details)
astippich added a subscriber: astippich.Jun 9 2018, 9:06 AM

the baloo interface will be part of kf 5.47, right?

astippich added a comment.Jun 24 2018, 8:42 AM

Can you please rebase? The base commit is quite old, and this currently makes the albummodel test fail here

mgallien updated this revision to Diff 36640.Jun 25 2018, 3:32 PM
mgallien edited the summary of this revision. (Show Details)

rebase as requested

Given baloo integration code is not yet auto tested, this is master only material.

astippich accepted this revision.Jun 26 2018, 8:34 PM
This revision is now accepted and ready to land.Jun 26 2018, 8:34 PM
Closed by commit R255:282e527e93f4: implement interface of Baloo to watch renamed files (authored by mgallien). · Explain WhyJun 27 2018, 8:11 PM
This revision was automatically updated to reflect the committed changes.
bruns added a subscriber: bruns.Apr 18 2020, 8:23 PM

Am I missing something, or is this essentially dead code?

If yes, then the corresponding code is Baloo is also useless ... I would like to remove the the metadatamover from Baloo, but the existence of this DBus interface is blocking that.

mgallien added a comment.Apr 19 2020, 8:18 PM
In D12584#651388, @bruns wrote:

Am I missing something, or is this essentially dead code?

If yes, then the corresponding code is Baloo is also useless ... I would like to remove the the metadatamover from Baloo, but the existence of this DBus interface is blocking that.

I am all for improving Baloo. It looks like I have forgot to properly add support for this interface in Elisa.

The starting idea behind this was to allow an application to be notified about moved files by itself without having to watch file system by itself.

I have failed to do it properly at that time but I am still interested to work on a solution if you agree ?

Revision Contents
Changeset List

Diff 36785

View Options

src/CMakeLists.txt

Loading...
View Options

src/baloo/localbaloofilelisting.cpp

Loading...