Differential D12481

Add dptr to models
ClosedPublic
Actions

Authored by nicolasfella on Apr 23 2018, 9:41 PM.

Details

Reviewers
drosca
apol
davidedmundson
Commits
R994:0abe8778072a: Add dptr to models
Summary

Last exported classes without dptr

Test Plan

Builds

Diff Detail

Repository
R994 Pulseaudio Qt Bindings
Branch
dptr
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolasfella created this revision.Apr 23 2018, 9:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 23 2018, 9:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Apr 23 2018, 9:41 PM
nicolasfella updated this revision to Diff 32920.Apr 23 2018, 9:44 PM
  • Coding style
nicolasfella updated this revision to Diff 32921.Apr 23 2018, 9:45 PM
  • Add license header
broulik added a subscriber: broulik.Apr 23 2018, 9:48 PM
broulik added inline comments.
src/models.h
47

The override is sufficient

81

Why void*?

src/models_p.h
27

Do we need an explicit Q_DECL_HIDDEN or something?

nicolasfella added inline comments.Apr 23 2018, 10:00 PM
src/models.h
81

So we can replace it with a "real" private class when we need it without creating a empty one now

nicolasfella updated this revision to Diff 32924.Apr 23 2018, 10:01 PM
  • Remove unneeded modifier
nicolasfella marked an inline comment as done.Apr 23 2018, 10:01 PM
davidedmundson accepted this revision.Apr 30 2018, 9:11 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
src/models_p.h
27

No. That's only needed for when people do

class AbstractModel::Private

where AbstractModel is exported

This revision is now accepted and ready to land.Apr 30 2018, 9:11 AM
Closed by commit R994:0abe8778072a: Add dptr to models (authored by nicolasfella). · Explain WhyApr 30 2018, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/models.h (27 lines)
Msrc/models.cpp (93 lines)
AMsrc/models_p.h (30 lines)

Diff 32919

View Options

src/models.h

Loading...
View Options

src/models.cpp

Loading...
View Options

src/models_p.h

Loading...