As this is clearly more readable:
y = sg.height() - (r.y() - sg.y() + r.height())

Put it in the code rather than reobfuscating it

@davidedmundson it seems like not only blitFromFramebuffer needs to convert coords from "virtual space" to "screen space". Maybe, there should be a helper like QRect GLRenderTarget::mapToScreenCoords(const QRect& rect) (or mapToScreenSpace). What do you think?

GLRenderTarget::mapToScreenCoords

mapFrom surely

but yes good idea

In D12466#253112, @davidedmundson wrote:

mapFrom surely

Not sure about mapFrom because we map coords to [OpenGL] screen space. But I guess that's a topic for another discussion.

Update: OK, mapFromVirtualSpace seems to be a good name.

Do you accept this change? :)

David, could you please land this patch for me?

In D12466#262289, @zzag wrote:

David, could you please land this patch for me?

You don't have a dev account @zzag?

In D12466#264043, @romangg wrote:

You don't have a dev account @zzag?

I asked sysadmins to withdraw my dev account(for security reasons) because I won't be contributing any time soon.