RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos
ClosedPublic

Authored by broulik on Mar 25 2016, 5:28 PM.

Details

Summary

Whenever we turn something on or off using a keyboard shortcut we should show an OSD.

Test Plan

Needs support in plasma-nm, obviously
Jens promised to look into the icons

Anybody have a shorter name for "Mobile Broadband"?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2956.Mar 25 2016, 5:28 PM
broulik retitled this revision from to RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 25 2016, 5:28 PM

Makes sense!
Sorry I don't know any shorter term for "mobile broadband". There are all sorts of acryonyms for individual mobile broadband technology, but since we don't know which one we're dealing with (or do we?), I fear we're stuck with that clunky term...

graesslin added inline comments.
shell/osd.cpp
139

Broadband? Does the generic user understand that? Maybe "Mobile Internet"?

jgrulich edited edge metadata.Mar 29 2016, 7:13 AM

Couldn't this be added to powerdevil? In my recent review for powerdevil I added options to turn off/on wifi/bt/wwan over DBus. I can also add support for this to plasma-nm of course.

Couldn't this be added to powerdevil?

We could do that, the OSD is quite indifferent on who calls it. I'm just not sure whether having the global shortcuts for toggling WiFi et al in PowerDevil rather than plasma-nm which usually manages all networking and has the respective check boxes in it.

mart added a subscriber: mart.Apr 22 2016, 8:39 AM

+1 on it,
tough kinda shows the limits of the kind of dbus interface it was chosen for doing osds, wouldn't know an alternative that looks less silly tough

mart accepted this revision.Apr 26 2016, 4:33 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Apr 26 2016, 4:33 PM
This revision was automatically updated to reflect the committed changes.