Differential D1223

[Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut
ClosedPublic
Actions

Authored by broulik on Mar 25 2016, 5:32 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma: Design
Plasma
Commits
R119:cf0bf81ccd4c: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut
Summary

Currently when the keyboard shortcut for turning on/off the touchpad, there's no feedback that something happened.

The OSD is only shown when the keyboard shortcut is pressed, not when changed through the applet or because you plugged in a mouse. When a mouse is plugged in a longer message explaining what happened already shows up.

Test Plan

Fn+F9, Touchpad off, got OSD, Fn+F9 again, touchpad on, got OSD

No OSD when using the touchpad applet

Depends on D1222

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2957.Mar 25 2016, 5:32 PM
broulik retitled this revision from to [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R119 Plasma Desktop.
broulik added a project: Plasma.
broulik added a dependency: D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 25 2016, 5:32 PM
graesslin accepted this revision.Mar 29 2016, 5:39 AM
graesslin added a reviewer: graesslin.
graesslin added a subscriber: graesslin.

We will need the same in KWin/Wayland (and actually also the code to enable/disable touchpad)

This revision is now accepted and ready to land.Mar 29 2016, 5:39 AM
Closed by commit R119:cf0bf81ccd4c: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut (authored by broulik). · Explain WhyApr 27 2016, 5:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3549

View Options

kcms/touchpad/src/kded/kded.h

Loading...
View Options

kcms/touchpad/src/kded/kded.cpp

Loading...