Differential D12154

Add OARS tags to the appdata
ClosedPublic
Actions

Authored by nickrichards on Apr 12 2018, 5:18 PM.

Details

Reviewers
apol
aacid
ltoscano
Group Reviewers
KDE Games
Commits
R418:4809c9c90eef: Add OARS tags to the appdata
Summary

Adds OARS tags to the appdata, they're used to give ratings in App Stores like KDE Discover https://hughsie.github.io/oars/

Diff Detail

Repository
R418 KTuberling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nickrichards created this revision.Apr 12 2018, 5:18 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 12 2018, 5:18 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
nickrichards requested review of this revision.Apr 12 2018, 5:18 PM
aacid added a comment.Apr 12 2018, 5:23 PM

Hmmm, not happy with things that need to be updated manually for each release :/

nickrichards updated this revision to Diff 31983.Apr 12 2018, 5:27 PM

Dropped the version tag for now, we can discuss how to add that more properly in a separate issue.

ltoscano added a subscriber: ltoscano.Apr 12 2018, 5:30 PM

The problem with release tags should be solved in a more global way by the release scripts IMHO.

The oars tags were already introduced in some other games, so I think that part of the change is fine (see https://phabricator.kde.org/D12154 )

ltoscano added a comment.Apr 12 2018, 5:31 PM

Can you please update the commit message too?

nickrichards retitled this revision from Add OARS and Version tags to the appdata to Add OARS tags to the appdata.Apr 12 2018, 5:34 PM
nickrichards edited the summary of this revision. (Show Details)
nickrichards added a comment.Apr 12 2018, 5:39 PM

I *think* I did that, let me know if there's something else I need to do. I use Phab all the time at work but we don't use differential so it's like the uncanny UI valley.

ltoscano accepted this revision.Apr 12 2018, 6:12 PM

It does seem fine, thanks, with one caveat: you did not use arcanist apparently, so there are no author metadata in the review.
Do you have commit access?

This revision is now accepted and ready to land.Apr 12 2018, 6:12 PM
nickrichards added a comment.Apr 12 2018, 6:48 PM

Nope, I'm just a drive by contributor.

Closed by commit R418:4809c9c90eef: Add OARS tags to the appdata (authored by nickrichards, committed by ltoscano). · Explain WhyApr 12 2018, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.ktuberling.appdata.xml (29 lines)

Diff 32000

View Options

org.kde.ktuberling.appdata.xml

Loading...