Add OARS tags to the appdata
ClosedPublic

Authored by nickrichards on Apr 12 2018, 5:18 PM.

Details

Summary

Adds OARS tags to the appdata, they're used to give ratings in App Stores like KDE Discover https://hughsie.github.io/oars/

Diff Detail

Repository
R418 KTuberling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nickrichards created this revision.Apr 12 2018, 5:18 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 12 2018, 5:18 PM
Restricted Application added a subscriber: KDE Games. · View Herald Transcript
nickrichards requested review of this revision.Apr 12 2018, 5:18 PM
aacid added a comment.Apr 12 2018, 5:23 PM

Hmmm, not happy with things that need to be updated manually for each release :/

Dropped the version tag for now, we can discuss how to add that more properly in a separate issue.

The problem with release tags should be solved in a more global way by the release scripts IMHO.

The oars tags were already introduced in some other games, so I think that part of the change is fine (see https://phabricator.kde.org/D12154 )

Can you please update the commit message too?

nickrichards retitled this revision from Add OARS and Version tags to the appdata to Add OARS tags to the appdata.Apr 12 2018, 5:34 PM
nickrichards edited the summary of this revision. (Show Details)

I *think* I did that, let me know if there's something else I need to do. I use Phab all the time at work but we don't use differential so it's like the uncanny UI valley.

ltoscano accepted this revision.Apr 12 2018, 6:12 PM

It does seem fine, thanks, with one caveat: you did not use arcanist apparently, so there are no author metadata in the review.
Do you have commit access?

This revision is now accepted and ready to land.Apr 12 2018, 6:12 PM

Nope, I'm just a drive by contributor.

This revision was automatically updated to reflect the committed changes.