Differential D12095

convert setDirLister to the new connect syntax
ClosedPublic
Actions

Authored by jtamate on Apr 10 2018, 5:31 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
Commits
R241:940d2763e41b: convert setDirLister to the new connect syntax
Summary

The only tricky part is the use of QOverload<>::of to distinguish between signals with same name but different signatures.

Test Plan

kdirmodeltest passes all tests.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Apr 10 2018, 5:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 10 2018, 5:31 PM
jtamate requested review of this revision.Apr 10 2018, 5:31 PM
apol accepted this revision.Apr 10 2018, 6:40 PM
apol added a subscriber: apol.

Should remove the private slot declaration?

This revision is now accepted and ready to land.Apr 10 2018, 6:40 PM
jtamate updated this revision to Diff 31851.Apr 11 2018, 6:41 AM

Someday, in a not so far future, I'll remember to always look for private slot definitions.

apol accepted this revision.Apr 11 2018, 1:44 PM
Closed by commit R241:940d2763e41b: convert setDirLister to the new connect syntax (authored by jtamate). · Explain WhyApr 11 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kdirmodel.h (7 lines)
Msrc/widgets/kdirmodel.cpp (20 lines)

Diff 31907

View Options

src/widgets/kdirmodel.h

Loading...
View Options

src/widgets/kdirmodel.cpp

Loading...