add a new ConstrainedSquare formfactor
Needs ReviewPublic

Authored by mart on Apr 9 2018, 4:22 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

It will make possible for applets to know they are in a systray-like
situation
BUG:388995

Test Plan

it will need the systray to actually make use of this

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Apr 9 2018, 4:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 9 2018, 4:22 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mart requested review of this revision.Apr 9 2018, 4:22 PM
kossebau added a subscriber: kossebau.EditedApr 9 2018, 4:36 PM

Commit message could see some "bug:388995" :)

"ConstrainedSquare" sounds like there could be other "Constrained*" in the future? Why this term combination instead of just "Square"?

mart edited the summary of this revision. (Show Details)Apr 9 2018, 4:37 PM
mart added a comment.Apr 9 2018, 4:39 PM

suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma 4 that was AspectRatio)
is i think the most correct name, even if less intuitive would be just "constrained"

apol added a subscriber: apol.Apr 10 2018, 7:50 AM
apol added inline comments.
src/plasma/plasma.h
89

Lacks < on the comment.

Zren added a subscriber: Zren.Apr 22 2018, 3:58 PM
In D12071#243259, @mart wrote:

suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma 4 that was AspectRatio)
is i think the most correct name, even if less intuitive would be just "constrained"

If so, let's change it to "Constrained" then, if there is a chance that the ratio can be different from 1:1.
Though, what about "Bounded" instead? Non-native speaker myself, but possibly sounds more close to real-estate boundaries also for others and might be more intuitive than the more abstract "constrained", which could refer to any kind of constraints. Also is the term used elsewhere in Qt API, also for the same purpose of describing limits.

Any plans to have fullscreen applets one day? There it would also be some vertically & horizontally constrained formfactor, would/should this new formfactor type also be used for such, or would there then be similar variants like there is for "Planar" with "Application" and "MediaCenter"?