Differential D12053

Increase SMTP session timeout to 1 minute
ClosedPublic
Actions

Authored by thiago on Apr 8 2018, 10:13 PM.

Details

Reviewers
marten
knauss
dfaure
dvratil
mlaurent
Commits
R733:f53cf6e95741: Increase SMTP session timeout to 1 minute
R733:5191948c4185: Increase SMTP session timeout to 1 minute
Summary

10 seconds is not enough to connect, establish a TLS session (STARTTLS)
and perform the HELO handshake on high-latency networks, like airplane
WiFi. Sending emails works just fine for non-encrypted connections, but
fails with "connection lost" on encrypted ones, even though tcpdump
shows there is traffic going on. We managed to trace this to this
10-second timeout.

Diff Detail

Repository
R733 KSmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thiago created this revision.Apr 8 2018, 10:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 8 2018, 10:13 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
thiago requested review of this revision.Apr 8 2018, 10:13 PM
dfaure accepted this revision.Apr 9 2018, 8:05 AM

Very cool, this might be the issue I've been seeing recently too.

(has this timeout been shortened during some recent rewrite?)

This revision is now accepted and ready to land.Apr 9 2018, 8:05 AM
dvratil added a comment.EditedApr 9 2018, 9:24 AM
In D12053#242998, @dfaure wrote:

(has this timeout been shortened during some recent rewrite?)

KSmtp is new since 17.12, previously the timeout was in the SMTP KIO Slave and was probably longer (didn't check).

Closed by commit R733:5191948c4185: Increase SMTP session timeout to 1 minute (authored by mlaurent). · Explain WhyApr 13 2018, 6:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/session.cpp (2 lines)

Diff 32036

View Options

src/session.cpp

Loading...