Differential D12051

[UDisks] Correct handling of removable file systems
ClosedPublic
Actions

Authored by bruns on Apr 8 2018, 8:33 PM.

Details

Reviewers
ngraham
broulik
Commits
R245:122a6cd8989a: [UDisks] Correct handling of removable file systems
Summary

Filesystems which have no fstab entry have an empty filepath (aka
mountpoint), but these should be mountable nevertheless.
The StorageAccess.ignored flag should only be used as a hint if a
device (filesystem) should create a device item in e.g Dolphin.

BUG: 391706
CCBUG: 389479

Diff Detail

Repository
R245 Solid
Branch
revert_empty_filepath_check
Lint
No Linters Available
Unit
No Unit Test Coverage
bruns created this revision.Apr 8 2018, 8:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 8 2018, 8:33 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 8 2018, 8:33 PM
ngraham accepted this revision.Apr 9 2018, 1:02 AM

Thanks, I can confirm that this fixes the automount issue for me. +1 for making the code clearer, too.

This revision is now accepted and ready to land.Apr 9 2018, 1:02 AM
Closed by commit R245:122a6cd8989a: [UDisks] Correct handling of removable file systems (authored by bruns). · Explain WhyApr 9 2018, 1:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31696

View Options

src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

Loading...