There is no reason to make mounting dependent on the StorageAccess.ignore
flag, which just serves a a hint for visualization.
This change sneaked in when porting to KF5, no justification given.
BUG: 389479
There is no reason to make mounting dependent on the StorageAccess.ignore
flag, which just serves a a hint for visualization.
This change sneaked in when porting to KF5, no justification given.
BUG: 389479
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
No, this commit *fixes* 389479, but it is a prerequisite for fixing 391706 (which is essentially a revert, thus would regress 389479).
EDIT: I can add 391706 as CCBUG ...
I did the KF5 port but I don't recall doing that or why it would be there, so +1 from me if it fixes that. I don't use automounter so I don't know
damn, that did not work as expected ... landed on master
should I just "arc land --onto Plasma/5.12" ?
Well it's too late now, but yes, that would have worked (in general, make sure to look before you land by first doing arc land --preview <any other options>). By default, arc lands the diff on the parent branch, which in this case was master.
Arc documentation is at https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
For now, you can cherry-pick the commit onto the 5.12 branch.
It irritated me too at first, but over time I found that it's fairly logical. In general, you just need to:
I really do recommend having a look at https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches. I and others have done a lot of work to document the behavior so that using arc shouldn't feel like a huge headache anymore.