Update contributors list and test

Authored by himanshuvishwakarma on Apr 7 2018, 7:31 PM.



Update contributors list & CMakeLists.txt of core tests

Diff Detail

Lint Skipped
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 7 2018, 7:31 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
himanshuvishwakarma requested review of this revision.Apr 7 2018, 7:31 PM
timotheegiet requested changes to this revision.Apr 8 2018, 10:44 AM

Please remove "l10n daemon script" from the list ;)

This revision now requires changes to proceed.Apr 8 2018, 10:44 AM
jjazeix added inline comments.Apr 8 2018, 12:08 PM

Can you also remove the duplicate people?

Remove the name l10n daemon script and I also removed the duplicate names from the list.

These names are repeating in the list, but their commits are present with the different email id. Currently, I removed the repeated names. Their List follows:
-> Holger Kaelberer <holger.k@elberer.de> <hk@getslash.de>
-> Stefan Toncu <stefan.toncu29@gmail.com> <stefan.toncu@cti.pub.ro>
-> Pulkit Gupta <pulkitgenius@gmail.com> <pulkitnsit@gmail.com>

Please confirm it

jjazeix accepted this revision.Apr 8 2018, 7:17 PM

Committed in https://commits.kde.org/gcompris/254738475d9b9c6158b66fd0080518dd00b83cd5
Next time, if there is a task linked to the commit please add it (and check before it's not assigned to someone else).
Thank you

timotheegiet accepted this revision.Apr 8 2018, 7:42 PM
This revision is now accepted and ready to land.Apr 8 2018, 7:42 PM
timotheegiet closed this revision.Apr 8 2018, 7:42 PM