himanshuvishwakarma (Himanshu Vishwakarma)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 27 2018, 7:55 AM (28 w, 4 d)
Availability
Available

Recent Activity

Jul 1 2018

himanshuvishwakarma removed a watcher for GCompris: himanshuvishwakarma.
Jul 1 2018, 9:15 AM

May 22 2018

himanshuvishwakarma added a comment to D12784: CoreDirectoryTest.

Commit Link: https://commits.kde.org/gcompris/fced0df7234fce50979cb261e5b6b61a3fde7b28

May 22 2018, 5:23 PM · KDE Edu, GCompris
himanshuvishwakarma committed R2:fced0df7234f: tests, Directory class is unit tested (authored by himanshuvishwakarma).
tests, Directory class is unit tested
May 22 2018, 5:17 PM

May 10 2018

himanshuvishwakarma requested review of D12806: CoreFileTest.
May 10 2018, 2:04 PM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D12784: CoreDirectoryTest.
May 10 2018, 1:31 PM · KDE Edu, GCompris

May 9 2018

himanshuvishwakarma requested review of D12784: CoreDirectoryTest.
May 9 2018, 4:51 PM · KDE Edu, GCompris

Apr 8 2018

himanshuvishwakarma updated the diff for D12031: Update contributors list and test.

Remove the name l10n daemon script and I also removed the duplicate names from the list.

Apr 8 2018, 6:12 PM · KDE Edu, GCompris

Apr 7 2018

himanshuvishwakarma requested review of D12031: Update contributors list and test.
Apr 7 2018, 7:31 PM · KDE Edu, GCompris

Mar 24 2018

himanshuvishwakarma abandoned D11658: Change in ActivityInfoTest.

Sorry Sorry Sorry...

Mar 24 2018, 8:22 PM · KDE Edu, GCompris
himanshuvishwakarma requested review of D11658: Change in ActivityInfoTest.
Mar 24 2018, 7:35 PM · KDE Edu, GCompris

Mar 23 2018

himanshuvishwakarma added a watcher for Kopete: himanshuvishwakarma.
Mar 23 2018, 9:43 PM
himanshuvishwakarma added a watcher for GCompris: himanshuvishwakarma.
Mar 23 2018, 7:43 PM
himanshuvishwakarma added a comment to D11034: CoreApplicationSettingsTest.

Can you check that if you instantiate a ApplicationSettingsMock object, then use ApplicationSettings::getInstance(), it returns the mock instead of creating a new ApplicationSettings object?
As we use it this way on other classes (like ApplicationInfo), it would be better that, for tests, the getInstance() returns the mock instead of the real one (else we'll have the same issue as we had here, writing on the real configuration).

Except this point (and the small one regarding parameters ordering), it seems good to me, I'll take a closer look this week-end to integrate it

Mar 23 2018, 10:10 AM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

Change in the order of the parameters, Make the QObject paramete in last.

Mar 23 2018, 10:10 AM · GCompris, KDE Edu

Mar 22 2018

himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

the created new header file (ApplicationSettingsMock)

Mar 22 2018, 2:50 AM · GCompris, KDE Edu

Mar 21 2018

himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

I am doing the mistake in the adding a protected constructor so, it gives the ambiguity error.

Mar 21 2018, 7:08 PM · GCompris, KDE Edu

Mar 20 2018

himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

Is this possible solution can be acceptable ??

Mar 20 2018, 5:51 PM · GCompris, KDE Edu

Mar 18 2018

himanshuvishwakarma added a comment to D11391: ecm_add_test method is added.

I am sorry, I haven't seen that you push it and make necessary changes as required.

Mar 18 2018, 1:32 AM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D11391: ecm_add_test method is added.

Now, extra-cmake-modules are not compulsory to compile the application but it required to run the unit test and other things.

Mar 18 2018, 1:27 AM · GCompris, KDE Edu

Mar 16 2018

himanshuvishwakarma added inline comments to D11391: ecm_add_test method is added.
Mar 16 2018, 7:54 PM · GCompris, KDE Edu
himanshuvishwakarma added a comment to D11034: CoreApplicationSettingsTest.

yes, I agree with you that if the test is crash during the running it will change the default settings of the application.

So, I think that the solution is that, I don't have to use the main settings( ~/.config/gcompris/gcompris-qt.conf ) of the application in our unit test. To achieve this, I tried with making DummyApplicationSettings class by inheriting the ApplicationSettings class and change access specifiers of m_config to protected and then tried to change the config file location but there is NO any function in the QSettings to change the location of the config file. So dummy class also changed the main settings of the application while running the test.

The main problem is NO way to change the default location of the config file in the object of QSettings class.

maybe wrong approach.
or
maybe some other method may present to do the tests. but presently I have no idea what to do next in this test, I am searching... if anything I will get, I will update the diff.

If you need to add some protected methods to change the settings, you can

Mar 16 2018, 3:25 PM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

Now, I removed the part which is changing the default settings of the GCompris

Mar 16 2018, 3:02 PM · GCompris, KDE Edu
himanshuvishwakarma added a project to D11391: ecm_add_test method is added: GCompris.
Mar 16 2018, 2:58 PM · GCompris, KDE Edu
himanshuvishwakarma requested review of D11391: ecm_add_test method is added.
Mar 16 2018, 2:55 PM · GCompris, KDE Edu

Mar 12 2018

himanshuvishwakarma added a comment to D11034: CoreApplicationSettingsTest.

yes, I agree with you that if the test is crash during the running it will change the default settings of the application.

Mar 12 2018, 4:54 PM · GCompris, KDE Edu

Mar 11 2018

himanshuvishwakarma added inline comments to D11034: CoreApplicationSettingsTest.
Mar 11 2018, 11:49 AM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.

Now the unit test is not changing the default configuration of the application.

Mar 11 2018, 11:49 AM · GCompris, KDE Edu

Mar 10 2018

himanshuvishwakarma added inline comments to D11034: CoreApplicationSettingsTest.
Mar 10 2018, 12:52 PM · GCompris, KDE Edu
himanshuvishwakarma added inline comments to D11034: CoreApplicationSettingsTest.
Mar 10 2018, 12:50 PM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D11034: CoreApplicationSettingsTest.
Mar 10 2018, 12:50 PM · GCompris, KDE Edu

Mar 4 2018

himanshuvishwakarma requested review of D11034: CoreApplicationSettingsTest.
Mar 4 2018, 9:26 PM · GCompris, KDE Edu

Mar 3 2018

himanshuvishwakarma added a comment to D10950: CoreActivityInfoTest.

Thanks for considering my patch.

Mar 3 2018, 5:24 PM · GCompris, KDE Edu

Mar 2 2018

himanshuvishwakarma added inline comments to D10950: CoreActivityInfoTest.
Mar 2 2018, 7:09 PM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D10950: CoreActivityInfoTest.

Pointer is removed

Mar 2 2018, 6:07 PM · GCompris, KDE Edu
himanshuvishwakarma updated the diff for D10950: CoreActivityInfoTest.

make the change in the autotest

Mar 2 2018, 5:17 PM · GCompris, KDE Edu

Mar 1 2018

himanshuvishwakarma requested review of D10950: CoreActivityInfoTest.
Mar 1 2018, 4:34 PM · GCompris, KDE Edu

Feb 21 2018

himanshuvishwakarma added reviewers for D10730: KopetePictureTest: pali, vijaykrishnavanshi.
Feb 21 2018, 9:45 PM · Kopete
himanshuvishwakarma requested review of D10730: KopetePictureTest.
Feb 21 2018, 9:43 PM · Kopete

Feb 17 2018

himanshuvishwakarma requested review of D10612: KopetePluginTest.
Feb 17 2018, 5:11 PM · Kopete

Feb 15 2018

himanshuvishwakarma added reviewers for D10556: Test is added in Jabber Protocol {JabberProtocolTest}: vijaykrishnavanshi, pali.
Feb 15 2018, 8:56 PM · Kopete
himanshuvishwakarma requested review of D10556: Test is added in Jabber Protocol {JabberProtocolTest}.
Feb 15 2018, 8:51 PM · Kopete

Feb 2 2018

himanshuvishwakarma updated the diff for D10160: Test for Crypt in QQ Protocol.

struct is removed

Feb 2 2018, 5:01 PM · Kopete

Feb 1 2018

himanshuvishwakarma added a comment to D10160: Test for Crypt in QQ Protocol.

the test is now data-driven test

Feb 1 2018, 6:29 AM · Kopete
himanshuvishwakarma updated the diff for D10160: Test for Crypt in QQ Protocol.
Feb 1 2018, 6:26 AM · Kopete

Jan 31 2018

himanshuvishwakarma updated subscribers of D10160: Test for Crypt in QQ Protocol.

I have some difficulties in making this test into the data-driven test.
For the data-driven, I have the problem in defining the array type the data
function. how to use this function to store the array type values

Jan 31 2018, 12:48 PM · Kopete

Jan 28 2018

himanshuvishwakarma updated the diff for D10160: Test for Crypt in QQ Protocol.
Jan 28 2018, 2:37 PM · Kopete
himanshuvishwakarma updated the diff for D10160: Test for Crypt in QQ Protocol.

Updated!

Jan 28 2018, 12:55 PM · Kopete