Indicates a bug in kfilemetadata delivering genre property when genre has no value.
- Copy appropiate sample files to no-meta/
- Remove tag data with picard or kid3
- Create test (of course)
Indicates a bug in kfilemetadata delivering genre property when genre has no value.
make test
No Linters Available |
No Unit Test Coverage |
I need more time. I will try to look at it today. By the way, the stack concept seems very useful. Thanks
autotests/taglibextractortest.cpp | ||
---|---|---|
231 | This converts the enums to strings. That way it is easier to spot which properties are responsible for the failure. |
Repeat 3. and 4. until finished
Updating a commit/revision:
autotests/taglibextractortest.cpp | ||
---|---|---|
231 | What he likely meant: |
Untested, but looks good to me otherwise.
autotests/taglibextractortest.cpp | ||
---|---|---|
42 | Nitpick - needs some indentation |
Sample files are broken, for no obvious reason. https://build.kde.org/view/Frameworks/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/lastBuild/
mpc with kid3-qt remove all tags and add ' ' as genre
autotests/taglibextractortest.cpp | ||
---|---|---|
240 | Unfortunately QCOMPARE does not do a deep compare if sizes mismatch. To get a better output in case the test fails, you can do something like: auto excessKeys() = ... auto missingKeys() = ... if (excessKeys().size()) { QWARN("Excess properties: " + excessKeys.join(", ")); if (!failMessage.isEmpty()) QEXPECT_FAIL(...) QCOMPARE(excessKeys.size(), 0); } if (missingKeys().size()) { ... } |