Differential D12002

Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway
ClosedPublic
Actions

Authored by fabiank on Apr 6 2018, 11:15 PM.

Details

Reviewers
mart
dfaure
mlaurent
Commits
R302:419e7ab659c1: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway
R302:49f871844632: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway
Test Plan

Run the steps described in the testplan of D12001. Without the patch, the
warning "Illegal icon group: 7" gets displayed, as Okular uses User icons.
Applying the patch fixes this; unit tests still run without failure.

Diff Detail

Repository
R302 KIconThemes
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fabiank created this revision.Apr 6 2018, 11:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 6 2018, 11:15 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
fabiank requested review of this revision.Apr 6 2018, 11:15 PM
dfaure accepted this revision.Apr 28 2018, 10:29 AM
This revision is now accepted and ready to land.Apr 28 2018, 10:29 AM
Closed by commit R302:49f871844632: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway (authored by fabiank). · Explain WhyMay 16 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 16 2018, 5:14 PM

Revision Contents
Changeset List

PathPackages
Msrc/kiconloader.cpp (2 lines)

Diff 34305

View Options

src/kiconloader.cpp

Loading...