Differential D12001

use correct filepath
ClosedPublic
Actions

Authored by fabiank on Apr 6 2018, 10:47 PM.

Details

Reviewers
hetzenecker
aacid
Group Reviewers
Okular
Commits
R223:c70485cd7442: use correct filepath
R223:f8f7a77fedc0: use correct filepath
R223:b25979121fd3: use correct filepath
Summary

Seems like someone forgot to consistently apply a change. Maybe the path
construction should be factored into a reusable lambda?

Test Plan

Open Okular, open settings > configure Okular. Without the patch, you'll get a
"QFSFileEngine::open: No file name specified" warning, with the patch it
disappears. Note that there is also an unrelated "Illegal icon group: 7"
warning from KIconThemes, but I'm 99% certain that this is on KIconThemes doing
a bogus check in KIconEffect::apply, not on Okular

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fabiank created this revision.Apr 6 2018, 10:47 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 6 2018, 10:47 PM
Restricted Application added a subscriber: Okular. · View Herald Transcript
fabiank requested review of this revision.Apr 6 2018, 10:47 PM
aacid accepted this revision.Apr 6 2018, 11:14 PM
aacid added a subscriber: aacid.

Ouch :D

This revision is now accepted and ready to land.Apr 6 2018, 11:14 PM
Closed by commit R223:f8f7a77fedc0: use correct filepath (authored by fabiank). · Explain WhyApr 6 2018, 11:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mui/pageviewannotator.cpp (2 lines)

Diff 31534

View Options

ui/pageviewannotator.cpp

Loading...