Fixed warnings that appear when building release version
Warnings as triggered by gcc-6.4.0:
[113/234 6.4/sec] Building CXX object krusader/JobMan/CMakeFiles/JobMan.dir/krjob.cpp.o
BUILD-DIR/krusader/krusader/JobMan/krjob.cpp: In static member function ‘static KrJob* KrJob::createKrCopyJob(KIO::CopyJob::CopyMode, const QList<QUrl>&, const QUrl&, KIO::JobFlags, KIO::CopyJob*, KIO::DropJob*)’:
BUILD-DIR/krusader/krusader/JobMan/krjob.cpp:79:40: warning: ‘type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
m_job(copyJob), m_dropJob(dropJob)
^BUILD-DIR/krusader/krusader/JobMan/krjob.cpp:56:10: note: ‘type’ was declared here
Type type;
^~~~BUILD-DIR/krusader/krusader/JobMan/krjob.cpp: In static member function ‘static KrJob* KrJob::createCopyJob(KIO::CopyJob::CopyMode, const QList<QUrl>&, const QUrl&, KIO::JobFlags)’:
BUILD-DIR/krusader/krusader/JobMan/krjob.cpp:79:40: warning: ‘type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
m_job(copyJob), m_dropJob(dropJob)
^BUILD-DIR/krusader/krusader/JobMan/krjob.cpp:56:10: note: ‘type’ was declared here
Type type;
^~~~[200/234 6.5/sec] Building CXX object krusader/Synchronizer/CMakeFiles/Synchronizer.dir/synchronizer.cpp.o
BUILD-DIR/krusader/krusader/Synchronizer/synchronizer.cpp: In member function ‘void Synchronizer::slotTaskFinished(KJob*)’:
BUILD-DIR/krusader/krusader/Synchronizer/synchronizer.cpp:1051:132: warning: ignoring return value of ‘int chown(const char*, uid_t, gid_t)’, declared with attribute warn_unused_result [-Wunused-result]
chown((const char *)(leftURL.adjusted(QUrl::StripTrailingSlash).path().toLocal8Bit()), newOwnerID, (gid_t) - 1);
^BUILD-DIR/krusader/krusader/Synchronizer/synchronizer.cpp:1052:132: warning: ignoring return value of ‘int chown(const char*, uid_t, gid_t)’, declared with attribute warn_unused_result [-Wunused-result]
chown((const char *)(leftURL.adjusted(QUrl::StripTrailingSlash).path().toLocal8Bit()), (uid_t) - 1, newGroupID);
^BUILD-DIR/krusader/krusader/Synchronizer/synchronizer.cpp:1088:133: warning: ignoring return value of ‘int chown(const char*, uid_t, gid_t)’, declared with attribute warn_unused_result [-Wunused-result]
chown((const char *)(rightURL.adjusted(QUrl::StripTrailingSlash).path().toLocal8Bit()), newOwnerID, (uid_t) - 1);
^BUILD-DIR/krusader/krusader/Synchronizer/synchronizer.cpp:1089:133: warning: ignoring return value of ‘int chown(const char*, uid_t, gid_t)’, declared with attribute warn_unused_result [-Wunused-result]
chown((const char *)(rightURL.adjusted(QUrl::StripTrailingSlash).path().toLocal8Bit()), (uid_t) - 1, newGroupID);
^[214/234 6.8/sec] Building CXX object krArc/CMakeFiles/kio_krarc.dir/krarc.cpp.o
BUILD-DIR/krusader/krArc/krarc.cpp: In member function ‘virtual void kio_krarcProtocol::put(const QUrl&, int, KIO::JobFlags)’:
BUILD-DIR/krusader/krArc/krarc.cpp:355:50: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
::write(fd, buffer.data(), buffer.size());
^[215/234 6.7/sec] Building CXX object iso/CMakeFiles/kio_iso.dir/kiso.cpp.o
In file included from BUILD-DIR/krusader/iso/libisofs/iso_fs.h:24:0,
from BUILD-DIR/krusader/iso/libisofs/isofs.h:29, from BUILD-DIR/krusader/iso/kiso.cpp:37:
BUILD-DIR/krusader/iso/kiso.cpp: In function ‘int mycallb(iso_directory_record*, void*)’:
BUILD-DIR/krusader/iso/kiso.cpp:271:69: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
QChar ch(be2me_16(*((ushort*)&(idr->name[i]))));
^BUILD-DIR/krusader/iso/libisofs/bswap.h:74:24: note: in definition of macro ‘bswap_16’
#define bswap_16(x) (((x) & 0x00ff) << 8 | ((x) & 0xff00) >> 8)
^
BUILD-DIR/krusader/iso/kiso.cpp:271:34: note: in expansion of macro ‘be2me_16’
QChar ch(be2me_16(*((ushort*)&(idr->name[i]))));
^~~~~~~~BUILD-DIR/krusader/iso/kiso.cpp:271:69: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
QChar ch(be2me_16(*((ushort*)&(idr->name[i]))));
^BUILD-DIR/krusader/iso/libisofs/bswap.h:74:46: note: in definition of macro ‘bswap_16’
#define bswap_16(x) (((x) & 0x00ff) << 8 | ((x) & 0xff00) >> 8)
^
BUILD-DIR/krusader/iso/kiso.cpp:271:34: note: in expansion of macro ‘be2me_16’
QChar ch(be2me_16(*((ushort*)&(idr->name[i]))));
^~~~~~~~Differential Revision: https://phabricator.kde.org/D11593