Fix missing entries in context menu for links

Authored by ngraham on Mar 21 2018, 11:00 PM.

Description

Fix missing entries in context menu for links

Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.

Test Plan:

  • Context menus for files, folders, and file links are unchanged.
  • The missing context menu items for folder links have returned:

I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.

Reviewers: rominf, michaelh, Dolphin, rkflx

Reviewed By: rominf, rkflx

Subscribers: rkflx

Differential Revision: https://phabricator.kde.org/D11562

Details

Committed
ngrahamMar 22 2018, 12:52 PM
Reviewer
rominf
Differential Revision
D11562: Fix missing entries in context menu for links
Parents
R318:1da0983c42a1: Fix compilation with -DQT_NO_URL_CAST_FROM_STRING
Branches
Unknown
Tags
Unknown
References
tag: v18.03.80