You can check if your output goes to a tty or is redirected:
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263

print as hex(major):hex(minor) ?

Use of Solid would be preferred.

No need for explicitly calling the default constructor, this is only needed for POD types (e.g. quint64).

That's great, thank you. I'll add some color to stdout in another patch.

Good idea was my first thought, but after trying, I must say it does not add really much info and makes the output harder to read.
The decimal is needed, because this function is mainly for selecting a deviceId to be used with 'clean', 'list' and upcoming 'repair' commands. I'd prefer to just print the decimal.

Sure? We would have to add Solid as a dependency for libKF5BalooEngine.so.
databasesanitizer currently is experimental not exported by default (You cannot see this because I haven't rebase yet.).
I did not use Solid, because I don't know it well and it seemed easier to copy and adapt FSUtils::getDirectoryFileSystem. I'm not objecting to use Solid though.

The true reason for 'fsutils`'s existence is to disable CoW on btrfs. Can Solid do that? If so we can drop fsutils.

Hey, that's an IIFE! Never seen it in C++ before.

I can not come up with a reason to use a MultiHash here in the first place - all that is needed is the deviceId and the file count per device.

You can use a QMap<DeviceId, Count> here, and use

usedDevices[info.deviceId] += 1;

(operator[] default-constructs the ValueType, which for e.g. int is guranteed by Qt to be 0).

This reduces the effort for counting the items per device from (D + 3) * F to F.
(D: number of devices, F: number of files).
Currently you walk the infos list once to create the MultiHash, and then walk the Multihash once for uniqueKeys(), and once for each device when calling usedDevices.value(). Cumulated effort for .count() is F.

In your case, this would reduce the time for counting by a factor of 14. You also save the memory for creating a temporary MultiHash with ~20000 items.

The question is if this really belongs in the library then.

IMHO the whole printDevices() function should be moved into baloodb.cpp, The DatabaseSanitizer should export either createList or a function returning QVector<DeviceId, Count>. Going from the DeviceId to the DeviceInfo should happen in baloodb.

Thanks!

I agree completely and followed your suggestion. Currently I'm stuck, though.
Using Solid to obtain the accessibilty info of volumes and network shares, it seems only Solid::Block provides the major and minor properties needed to map to deviceId. But network shares don't implement Block. :-/
Any ideas? Maybe that is the reason why BalooEngine isn't using Solid?

While implementing your "I can not come up with a reason ..." suggestion, I realized, the 'clean' command also needs DeviceInfo to exclude unmounted devices.

Which is good, as the device id is completely bogus, and changes dependent on mount order.

Also the inode is not generally stable for at least smb, as not every server supports inodes exported from the server, and can not when several server filesystems are exported as a single share.

baloo on network shares will likely never work.

Will try to use QStorageInfo

instead of checking and filling it in here, just iterate over usedDevices after you have finished iterating over infos.

Hm how about device:2052 [0:804] or device:2052 [0000:0804]?

That somehow sneaked back in. Your suggestion is good. I'll use it.

Better safe than sorry here. Otherwise all items of share might be removed with baloodb clean.

Will be removed downstream

Completely overlooked this one - should have used QStorageInfo::mountedVolumes() here instead.
http://doc.qt.io/qt-5/qstorageinfo.html#mountedVolumes