Differential D11390

new icons for disconnected/disabled devices
ClosedPublic
Actions

Authored by mart on Mar 16 2018, 2:41 PM.

Details

Reviewers
andreask
Group Reviewers
Plasma
VDG
Commits
R242:5163e3e9ff69: new icons for disconnected/disabled devices
Summary

there were some icons which conveyed meaning solely by color
which is discouraged by the hig
https://community.kde.org/KDE_Visual_Design_Group/HIG/Color
this makes use of the little x corner icons that are already
used somewhere in breeze (like muted microphone)
the exception is wireless off that has a bar, so a stronger
this is disabled message than wireless-disconnected

Depends on D10243
...which should go in asap

Test Plan

they all look readable at 100% zoom

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 16 2018, 2:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 16 2018, 2:41 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mart requested review of this revision.Mar 16 2018, 2:41 PM
andreask accepted this revision.Mar 16 2018, 2:50 PM
andreask added a subscriber: andreask.

look good to me thanks

This revision is now accepted and ready to land.Mar 16 2018, 2:50 PM
mart added a comment.Mar 16 2018, 3:14 PM
In D11390#227284, @andreask wrote:

look good to me thanks

should i go hunting in breeze icons as well to see if there are some to update to make it look the same?

mart added a comment.Mar 16 2018, 3:15 PM

ah, if i push this, it will override D10243 which shouldn't be pushed anymore (it contains all the new darker icons)

Closed by commit R242:5163e3e9ff69: new icons for disconnected/disabled devices (authored by mart). · Explain WhyMar 16 2018, 3:16 PM
This revision was automatically updated to reflect the committed changes.
acrouthamel awarded a token.Mar 16 2018, 3:52 PM
acrouthamel added a subscriber: acrouthamel.

They look great!

Revision Contents
Changeset List

Diff 29687

View Options

src/desktoptheme/breeze/icons/network.svgz

Loading...