Don't make Headings 20% transparent, to match Kirigami
ClosedPublic

Authored by ngraham on Feb 27 2018, 7:04 PM.

Details

Summary

We recently removed Kirigami Headings' slight transparency, after concluding that it looked inappropriate to have Headings with lighter text than their textual content. PlasmaExtras.Heading does the same thing, so we should make the same change here, both based on the inherent merits of the change, and also to maintain consistency with Kirigami.

This also slightly improves matters for people who complain about poor text contrast throughout Plasma.

Test Plan

Browsed System Settings; headings are now ever so slightly darker (or lighter, for users of Dark themes)

Also, here are some befores-and-afters for a widget I'm working on that uses Headings. Before:

After:

It's subtle; you'll need to flip between the two with the arrow keys to see the difference, and may need to also zoom in (meta++)

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
opaque-headers (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Feb 27 2018, 7:04 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 27 2018, 7:04 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
ngraham requested review of this revision.Feb 27 2018, 7:04 PM
ngraham edited the summary of this revision. (Show Details)Feb 27 2018, 7:05 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)Feb 27 2018, 7:08 PM
mart accepted this revision.Feb 27 2018, 7:11 PM
This revision is now accepted and ready to land.Feb 27 2018, 7:11 PM
ngraham closed this revision.Feb 27 2018, 7:13 PM