Looks ok, but this commit is a bit too small ;) It would make more sense to integrate this with the code that's calling addTemporaryAuthorization, so we can see how that all works.

This revision is now accepted and ready to land.Mar 4 2018, 10:30 AM

Rebased on D10568
Merged D10437

chinmoyr mentioned this in D10437: Update file ioslave's temporary authorization list.Apr 3 2018, 6:07 PM

chinmoyr added inline comments.Apr 3 2018, 6:10 PM

src/core/slavebase.cpp
129	@dfaure where should I place this variable? Just before "m_confirmationAsked"?

Rearranged member vars

Closed by commit R241:ec4df175be47: Store PolicyKit action which the slave is authorized to perform (authored by chinmoyr). · Explain WhyApr 4 2018, 3:45 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/slavebase.h (9 lines)
M			src/core/slavebase.cpp (6 lines)
M			src/ioslaves/file/file_unix.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27990	652564f		Feb 25 2018, 9:41 AM	★	★
Diff 2	28537	652564f	m_TempAuth -> m_temAuths	Mar 4 2018, 3:58 AM	★	★
Diff 3	31227	0e45fcf	Rebased on D10568	Apr 3 2018, 6:01 PM	★	★
Diff 4	31249	0e45fcf	Rearranged member vars	Apr 4 2018, 3:41 AM	★	★
Diff 5	31250	0e45fcf	R241:ec4df175be475ac5844996709cef72c4f9e7ac65	Apr 4 2018, 3:40 AM	★	★

Store PolicyKit action which the slave is authorized to perform
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 31227

src/core/slavebase.h

src/core/slavebase.cpp

src/ioslaves/file/file_unix.cpp

Store PolicyKit action which the slave is authorized to performClosedPublicActions