Differential D10777

Define __ANDROID_API__
ClosedPublic
Actions

Authored by vkrause on Feb 23 2018, 7:23 PM.

Details

Reviewers
apol
Group Reviewers
Build System
Commits
R240:bbf792fc28c2: Define __ANDROID_API__
Summary

This is needed for NDK headers to work correctly, and is the same as the
CMake code in the NDK does.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
vkrause created this revision.Feb 23 2018, 7:23 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptFeb 23 2018, 7:23 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vkrause requested review of this revision.Feb 23 2018, 7:23 PM
apol accepted this revision.Feb 23 2018, 11:26 PM
apol added a subscriber: apol.

I've never seen these so I'm surprised. Good that you figured it out though :)

Can you remove the comment above?

This revision is now accepted and ready to land.Feb 23 2018, 11:26 PM
vkrause added a comment.Feb 24 2018, 9:07 AM
In D10777#212384, @apol wrote:

I've never seen these so I'm surprised. Good that you figured it out though :)

As long as you stick with Qt API this probably doesn't matter, I only ran into this with libc API.

Can you remove the comment above?

Sure.

Closed by commit R240:bbf792fc28c2: Define __ANDROID_API__ (authored by vkrause). · Explain WhyFeb 24 2018, 9:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtoolchain/Android.cmake (2 lines)

Diff 27875

View Options

toolchain/Android.cmake

Loading...