Define __ANDROID_API__
ClosedPublic
Actions

Authored by vkrause on Feb 23 2018, 7:23 PM.

Details

Reviewers

apol

Group Reviewers

Build System

Commits

R240:bbf792fc28c2: Define __ANDROID_API__

Summary

This is needed for NDK headers to work correctly, and is the same as the
CMake code in the NDK does.

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

vkrause requested review of this revision.Feb 23 2018, 7:23 PM

I've never seen these so I'm surprised. Good that you figured it out though :)

Can you remove the comment above?

This revision is now accepted and ready to land.Feb 23 2018, 11:26 PM

In D10777#212384, @apol wrote:

I've never seen these so I'm surprised. Good that you figured it out though :)

As long as you stick with Qt API this probably doesn't matter, I only ran into this with libc API.

Can you remove the comment above?

Sure.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			toolchain/Android.cmake (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27875	ca65aab		Feb 23 2018, 7:23 PM	★	★
Diff 2	27902	ca65aab	R240:bbf792fc28c258ced4e46ed0d0a3cd0691e4016d	Feb 24 2018, 9:10 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6d684862836f	d0c7b437c569	ca65aab3a12b	Volker Krause	Define __ANDROID_API__ (Show More…)	Feb 23 2018, 7:15 PM