Differential D10671

[UDisks] Fix auto-mount regression
ClosedPublic
Actions

Authored by dkhlestkov on Feb 19 2018, 10:28 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Commits
R245:e94ba0619477: [UDisks] Fix auto-mount regression
Summary

BUG: 389479
Devices with empty path stopped auto-mounting after commit 1384f275ab2f1ad1841753ee163af6d1b0bb952b.
This diff fixes the regression by checking if the path is empty.

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dkhlestkov created this revision.Feb 19 2018, 10:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 19 2018, 10:28 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dkhlestkov requested review of this revision.Feb 19 2018, 10:28 PM
rikmills added a subscriber: rikmills.Feb 19 2018, 10:38 PM

I assume this would be safe to backport to 5.43, should it be accepted?

dkhlestkov added a comment.Feb 19 2018, 10:41 PM

yes, this would be safe

ngraham added a subscriber: ngraham.Feb 19 2018, 10:46 PM

FWIW we will need an email address to land this patch if it is accepted. In the future, if you use Arc to submit the patch, this step won't be necessary.

dkhlestkov added a comment.Feb 20 2018, 6:45 AM
In D10671#209868, @ngraham wrote:

we will need an email address to land this patch if it is accepted

How do I provide it? I see no corresponding input field.

broulik accepted this revision.Feb 20 2018, 8:53 AM

I added a similar check in Storage Volume but did not here.. :/

I can confirm that those "Loop Devices" are still ignored, which is good.

This revision is now accepted and ready to land.Feb 20 2018, 8:53 AM
ngraham added a comment.Feb 20 2018, 8:24 PM
In D10671#209941, @dkhlestkov wrote:
In D10671#209868, @ngraham wrote:

we will need an email address to land this patch if it is accepted

How do I provide it? I see no corresponding input field.

Just put it in a comment here.

dkhlestkov added a comment.Feb 20 2018, 9:03 PM

dsx.box@yandex.ru

dkhlestkov retitled this revision from Fix auto-mount regression to [UDisks] Fix auto-mount regression.Feb 21 2018, 9:58 AM
ngraham added a comment.Feb 22 2018, 3:12 PM

Can this land?

ngraham added a comment.Feb 23 2018, 2:37 PM

Do any Frameworks folks want to chime in before I land this?

ngraham added a comment.Feb 24 2018, 2:16 PM

Looks like not. Landing it.

Closed by commit R245:e94ba0619477: [UDisks] Fix auto-mount regression (authored by dkhlestkov, committed by ngraham). · Explain WhyFeb 24 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.
bruns added a subscriber: bruns.Apr 6 2018, 7:34 PM

Revision Contents
Changeset List

Diff 27916

View Options

src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

Loading...