Differential D10661

indexerconfig: Expose canBeSearched function
ClosedPublic
Actions

Authored by michaelh on Feb 19 2018, 4:05 PM.

Details

Reviewers
dfaure
lbeltrame
Group Reviewers
Baloo
Dolphin
Commits
R293:67a84fe99a03: indexerconfig: Expose canBeSearched function
Summary

Make D10205 public

CCBUG:388656

Diff Detail

Repository
R293 Baloo
Branch
expose_canbesearched (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Feb 19 2018, 4:05 PM
Restricted Application added a subscriber: Frameworks. · View Herald TranscriptFeb 19 2018, 4:05 PM
michaelh requested review of this revision.Feb 19 2018, 4:05 PM
adridg added a subscriber: adridg.Feb 21 2018, 9:17 AM
adridg added inline comments.
src/lib/indexerconfig.h
42 ↗(On Diff #27551)

This description says only includeFolders() is taken into account. The next paragraph says "should be indexed", which suggests that the function shouldBeIndexed() is involved -- but that does a whole different set of checks, also using the excludes. Either rephrase to avoid the "should be indexed" verb here, or make more clear what exactly the criterium is.

47 ↗(On Diff #27551)

Probably \c true, see also D10662.

michaelh updated this revision to Diff 27667.Feb 21 2018, 11:00 AM
  • indexerconfig: Rephrase description
michaelh marked 2 inline comments as done.Feb 21 2018, 11:08 AM
lbeltrame accepted this revision.Feb 22 2018, 1:03 PM
lbeltrame added a subscriber: lbeltrame.

For what it's worth, LGTM .

This revision is now accepted and ready to land.Feb 22 2018, 1:03 PM
Closed by commit R293:67a84fe99a03: indexerconfig: Expose canBeSearched function (authored by michaelh). · Explain WhyFeb 22 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/indexerconfig.h (11 lines)
Msrc/lib/indexerconfig.cpp (6 lines)

Diff 27667

View Options

src/lib/indexerconfig.h

Loading...
View Options

src/lib/indexerconfig.cpp

Loading...