Depends on D10659
BUG: 361968
FIXED-IN: 5.13.0
Details
Details
Hit Return after opening dialog, closed
Hit Return with search focused but nothing in it, closed
Hit Return with search query, started search (no search providers seem to be enabled by default, though, and no hint is provided why I cannot search..)
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Not tested, but seems good to me by pure reading.
| applets/weather/package/contents/ui/config/ConfigWeatherStation.qml | ||
|---|---|---|
| 33 | Slightly undecided: given above we use the length property as implicit bool, dping a value comparison here instead seems inconsistent. Just saying, no own preference and not enough years of JS/QML done to have strong opinions about it :) Do we have some accepted JS tricks with Plasma code style? | |
Comment Actions
Blocked a little by me having the desire to have the secret API used here made public documented, cmp. question to you in https://phabricator.kde.org/D10659#212230
No alternative solution from myself otherwise, so if you think this is a future-proof solution, fine with me.
Comment Actions
yeah, for me that other patch is ok, is not optimal but should all be documented in line in that file
maaaybe introducing a root component for those config uis.. not sure
| applets/weather/package/contents/ui/config/ConfigWeatherStation.qml | ||
|---|---|---|
| 33 | could be "readonly property" as well, no? | |
Comment Actions
I would like to consider discarding this patch and the related introduction of the "acceptOnReturnPressed" property to Plasma config page concept only needed for this so far.
I am currently drafting to rework the UI of the weather station page in the dialog, to add support for multiple stations (following request to match feature of the old yawp widget).
And instead of having the current embedded weather station picker, whose interaction pattern has been reported to be confusing at least to some, go to follow the pattern as we know it from e.g. the file picker, where another separate subdialog is opened for just that purpose of selecting an item.