[AppletConfiguration] Let applet override Return closing the dialog
AbandonedPublic

Authored by broulik on Feb 19 2018, 3:04 PM.

Details

Reviewers
kossebau
Group Reviewers
Plasma
Summary

In weather applet, pressing Return should invoke the search rather than closing the dialog.
When this property is set, pressing Return will not close the dialog.

Test Plan

Normal applet dialog closes as usual, saving changes. When property is set, hitting Return keeps dialog open. Escape is unaffected.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 19 2018, 3:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 19 2018, 3:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 19 2018, 3:04 PM

Eek. Undocumented secret properties make my toe nails roll up.

Can this property become something more official, with real documentation (and test case), so that other applet config pages can make use of it as well?
No real insight into design of applet confiuration myself, so otherwise shy to comment on this at all.

Can this property become something more official, with real documentation

Sure. If you tell me where the other features of the config dialog (e.g. the saveConfig() function ) is documented, I'd happily add it there.

kossebau added a subscriber: mart.Feb 23 2018, 5:31 PM

Can this property become something more official, with real documentation

Sure. If you tell me where the other features of the config dialog (e.g. the saveConfig() function ) is documented, I'd happily add it there.

Indeed I have no idea where that is. But we would agree it should, right?
@mart Given you designed the control UI framework IIRC, what have been your ideas about documenting this?

mart added a comment.Mar 23 2018, 2:22 PM

to me is fine..
already the main item can implement functions that can do $stuff, which is not abvious and could be bertter.
i guess the best thing is to put a big text comment here what are the supported comments/functions

broulik abandoned this revision.May 16 2018, 11:42 AM