Reorganize tools button menu for best user experience
ClosedPublic

Authored by rkflx on Feb 15 2018, 9:34 PM.

Details

Summary

After 5206cdda2292, 7034b50c5c9e and 45c37a64e1cc were worked on in
parallel and added entries to the new Tools menu, it was necessary
to put them in the right order in the end.

The suggestion in D10542#207008 was met with approval, as
Open Screenshots Folder seems like an often used feature and
therefore belongs on top, and Record Screen is only slightly
related to the actual screenshot and thus can go at the bottom.

Ref T7841

Test Plan
Menu still works, same order as in planned docbook patch (see D10542).

Diff Detail

Repository
R166 Spectacle
Branch
tools-menu (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
rkflx requested review of this revision.Feb 15 2018, 9:34 PM
rkflx created this revision.
ngraham accepted this revision.Feb 15 2018, 9:47 PM
ngraham added a subscriber: ngraham.

Makes sense and works fine. And nice job including tracking information with your branches, BTW! I recently updated the Phabricator wiki page to recommend that.

This revision is now accepted and ready to land.Feb 15 2018, 9:47 PM
rkflx added a comment.EditedFeb 15 2018, 9:55 PM

I recently updated the Phabricator wiki page to recommend that.

Thanks, I noticed. arc feature f2 or arc fe f2 would be faster to type than git checkout -t -b <branch name for feature 2> --track <branch name for feature 1>, though. On the other hand, with the long form it might be easier to understand what's happening, and having both would be confusing? Hmh...

Also: Why do you have -t and --track?

I recently updated the Phabricator wiki page to recommend that.

Thanks, I noticed. arc feature f2 or arc fe f2 would be faster to type than git checkout -t -b <branch name for feature 2> --track <branch name for feature 1>, though. On the other hand, with the long form it might be easier to understand what's happening, and having both would be confusing? Hmh...

That was deliberate, to help people understand what's actually happening under the hood (the people most upset about Phabricator seem to be the ones who don't get what it's doing).

Also: Why do you have -t and --track?

An oversight; will fix.

This revision was automatically updated to reflect the committed changes.

Screenshot looks great.