[Mouse KCM] Check libinput Atom availability before using them
ClosedPublic

Authored by broulik on Feb 7 2018, 9:38 AM.

Details

Summary

Otherwise the KCM aborts on XWayland.

CHANGELOG: Fixed mouse settings module crashing on Wayland

BUG: 389978
FIXED-IN: 5.12.1

Test Plan

KCM starts fine on Wayland now, previously it would quit with BadAtom error

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 7 2018, 9:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 7 2018, 9:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 7 2018, 9:38 AM
davidedmundson accepted this revision.Feb 7 2018, 11:36 AM
davidedmundson added a subscriber: davidedmundson.

If we're on wayland, why are we even loading x11mousebackend at all?
Can it not be guarded there?

This revision is now accepted and ready to land.Feb 7 2018, 11:36 AM
romangg added a comment.EditedFeb 7 2018, 11:42 AM

If we're on wayland, why are we even loading x11mousebackend at all?
Can it not be guarded there?

Martin implemented some hack in KWin for the short term to make cursor speed adjustable on Wayland via the X11 value. As soon as this is done properly without the hack instead, I believe we do not need to load it anymore.

Doing this properly is one of my work items for 5.13.

This revision was automatically updated to reflect the committed changes.