| dfaure | |
| mlaurent |
Does the same as K_PLUGIN_FACTORY_WITH_JSON but saves you typing the class name twice.
If you look at lxr.kde.org you can see our codebase is full of stuff like
K_PLUGIN_FACTORY_WITH_JSON(NinjaBuilderFactory, "kdevninja.json", registerPlugin<NinjaBuilder>(); )
where we repeat NinjaBuilder twice, so add a nice macro so that we only have to write it once
| No Linters Available |
| No Unit Test Coverage |
+1
I'd welcome that. I always found odd to have to invent a name that wouldn't be required on the rest of the program.
Makes sense to me to have a shorter version for the common case of just one registered plugin. Less boilerplate :)
Please add a note in the API dox that this macro is for the case of just one plugin class, and link to K_PLUGIN_FACTORY_WITH_JSON for the case someone wants multiple plugins (yes, there are some use-cases for that).
Please also add K_PLUGIN_CLASS_WITH_JSON (or whatever name it will be in the end) to the list KCoreAddons_AUTOMOC_MACRO_NAMES in the toplevel CMakeLists.txt.
Hmm, i already have a \see K_PLUGIN_FACTORY_WITH_JSON my guess is that people that find out that this doesn't do what they want, they'll go there?
Please also add K_PLUGIN_CLASS_WITH_JSON (or whatever name it will be in the end) to the list KCoreAddons_AUTOMOC_MACRO_NAMES in the toplevel CMakeLists.txt.
Done, thanks.
And yes, I'm open for better naming, not totally happy with it to be honest.
| src/lib/plugin/kpluginfactory.h | ||
|---|---|---|
| 211 | it's doesn't work. jsonFile in all macro or json only | |