Removed call to settings.readConfig() in ViewSettingsTab::loadSettings(),
because it overwrites default settings with user settings even if called
from ViewSettingsTab::restoreDefaultSettings().
Details
Details
Settings -> Configure Dolphin -> View Modes:
Choose "Custom Font", "Choose...": other font settings than preselected;
alter "Icon Size" slider positions;
click OK; OK;
note modified text font next to icons, icon sizes
Settings -> Configure Dolphin -> View Modes:
Click "Defaults"
check "Font" is reset to "System Font";
check "Icon Size" slider positions are reset to default positions;
click OK
check text font next to icons, icon sizes are reset to defaults
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/settings/viewmodes/viewsettingstab.cpp | ||
|---|---|---|
| 236 | This was added to fix https://bugs.kde.org/show_bug.cgi?id=292698 Can you please check that this patch does not reintroduce that bug? | |
Comment Actions
Please also reduce the length of the description (first line): https://chris.beams.io/posts/git-commit/
Comment Actions
I changed the title of this revision. Is this sufficient or is a new commit needed?
| src/settings/viewmodes/viewsettingstab.cpp | ||
|---|---|---|
| 236 | I checked https://bugs.kde.org/show_bug.cgi?id=292698 , tried out to reproduce the described behaviour using scenarios from description and comment 2: https://bugs.kde.org/show_bug.cgi?id=292698#c2 Icons stay at the expected size set in the status bar when changing font width in the settings. Icons don't change sizes unexpectedly. | |
Comment Actions
Can you please expand the "Test Plan" section with details on how to reproduce the issue fixed by this patch?
| src/settings/viewmodes/viewsettingstab.cpp | ||
|---|---|---|
| 235–236 | Makes sense and fixes the bug. But please make the settings variable const, like it was before the readConfig() call was added. | |